correct pa config path #730
Conversation
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gregsheremeta The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
A new image has been built to help with testing out this PR: To use this image run the following: cd $(mktemp -d)
git clone [email protected]:opendatahub-io/data-science-pipelines-operator.git
cd data-science-pipelines-operator/
git fetch origin pull/730/head
git checkout -b pullrequest ebab2e1f78611a0458c72724c52a7cf3ef05c9a3
oc new-project opendatahub
make deploy IMG="quay.io/opendatahub/data-science-pipelines-operator:pr-730"More instructions here on how to deploy and test a Data Science Pipelines Application. |
this will match the config path to what we are specifying for env vars for the pa image foudn in config/base/params.env i.e. IMAGES_PERSISTENCEAGENT should match Images.PersistenceAgent Signed-off-by: Humair Khan <[email protected]>
|
Change to PR detected. A new PR build was completed. |
|
Please take a look at the failed Integration test. |
|
New changes are detected. LGTM label has been removed. |
|
Change to PR detected. A new PR build was completed. |
|
Change to PR detected. A new PR build was completed. |
HumairAK
force-pushed
the
fix_pa_path
branch
2 times, most recently
from
5ad56be to
7a91f08
Compare
|
Change to PR detected. A new PR build was completed. |
Signed-off-by: Humair Khan <[email protected]>
|
Change to PR detected. A new PR build was completed. |
this will match the config path to what we are specifying for env vars
for the pa image found in config/base/params.env i.e.
IMAGES_PERSISTENCEAGENT should match Images.PersistenceAgent