Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update *_task.yaml files with correct test path #101

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

MichaelClifford
Copy link
Collaborator

@MichaelClifford MichaelClifford commented Oct 16, 2024

Closes #82

This PR updates update_test_lines_in_files() to correctly set the correct file paths in the *_task.yaml.

Copy link
Collaborator

@sallyom sallyom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a much cleaner way to update the yaml. We'll keep an eye on this issue: instructlab/sdg#312, the real fix will go into SDG, but this works for now!
LGTM

@sallyom sallyom merged commit bc97a97 into opendatahub-io:main Oct 17, 2024
1 check passed
Copy link
Collaborator

@leseb leseb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes should have gone in standalone.tpl :/

EDIT: actually no, but it looks like the file wasn't formatted 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants