Pipeline Updates for RHEL AI 1.3 #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Clifford <[email protected]>
Signed-off-by: Michael Clifford <[email protected]>
MichaelClifford
force-pushed
the
rhel1.3
branch
from
6c6de40 to
ba97769
Compare
|
EDIT: not quite, this b235539 works 💯 though |
leseb
force-pushed
the
rhel1.3
branch
2 times, most recently
from
aee44dd to
cb305a1
Compare
On 1.3, we cannot edit /usr/share/instructlab/sdg/default_data_recipes/skills.yaml, thus we had to make adjustments to override the SDG DataMixer class to pass a different skills file. Also, sdg_sampling_size is now optional in the pipeline. Signed-off-by: Sébastien Han <[email protected]>
MichaelClifford
force-pushed
the
rhel1.3
branch
from
319d3db to
b1cc706
Compare
Signed-off-by: Michael Clifford <[email protected]>
MichaelClifford
force-pushed
the
rhel1.3
branch
from
b1cc706 to
262fb94
Compare
MichaelClifford
changed the title
3 tasks
sallyom
reviewed
Dec 6, 2024
| chunk_word_count=1000, | ||
| server_ctx_size=4096, | ||
| ) | ||
| # Tweak precomputed skills data ratio if needed |
There was a problem hiding this comment.
We should add more explanation for this since it differs from what's exposed in ilab CLI? Or, link to an issue to replace this once the equivalent is in ilab/sdg? This can be a follow-up.
leseb
reviewed
Dec 9, 2024
| # Override XDG_DATA_DIRS with the temporary directory | ||
| # This allows SDG to read the new skills.yaml since it's looking into XDG_DATA_DIRS | ||
| # and looks for a default_data_recipes directory with a skills.yaml file | ||
| os.environ["XDG_DATA_DIRS"] = f"{temp_dir}" |
There was a problem hiding this comment.
Let's keep the override here instead of doing data_processing_task.set_env_variable so that removing this code will be easier in the future. Nothing to change!
leseb
approved these changes
Dec 9, 2024
tumido
reviewed
Dec 9, 2024
Do not use None since it is not supported by the pipeline. Use the default 1.0 and compare against it to determine whether we need to tweak it. Signed-off-by: Sébastien Han <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the pipeline to use the RHEL AI 1.3 image.
In addition to updating the image, a couple other updates had to be made:
XDG_CACHE_HOMEto/tmpfor thedata_processing_task.set_precomputed_skills_data_ratio()to use a temporary directory when needed in thesdg_opcomponent.main_ds.py.