-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement gRPC GetArtifactType #26
Implement gRPC GetArtifactType #26
Conversation
ctx, dbConn := Begin(ctx, g.dbConnection) | ||
defer handleTransaction(ctx, &err) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I preferred to take "same approach" and place this on a tx context too, even if this is only a read, for consistency.
e12affc
to
def917b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add the test client code to the current prototype integration test test/python/test_mlmetadata.py
script. We can re-use it in a later testframework.
b3965ba
to
ae1e617
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
no vetos, no missing, all approval; proceeding to merge. |
resolves #25
Description
Implement gRPC
GetArtifactType
How Has This Been Tested?
in one terminal:
in another terminal:
then running the following python script:
Outputs as expected:
Merge criteria: