Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement gRPC GetArtifactType #26

Merged
merged 2 commits into from
Sep 27, 2023
Merged

Implement gRPC GetArtifactType #26

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2083ca0
Implement gRPC GetArtifactType
tarilabs Sep 25, 2023
ae1e617
Add test client code to current prototype IT
tarilabs Sep 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 32 additions & 3 deletions internal/server/grpc_server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,9 +266,38 @@ func (g grpcServer) PutParentContexts(ctx context.Context, request *proto.PutPar
panic("implement me")
}

func (g grpcServer) GetArtifactType(ctx context.Context, request *proto.GetArtifactTypeRequest) (*proto.GetArtifactTypeResponse, error) {
//TODO implement me
panic("implement me")
func (g grpcServer) GetArtifactType(ctx context.Context, request *proto.GetArtifactTypeRequest) (resp *proto.GetArtifactTypeResponse, err error) {
ctx, dbConn := Begin(ctx, g.dbConnection)
defer handleTransaction(ctx, &err)
Comment on lines +270 to +271
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I preferred to take "same approach" and place this on a tx context too, even if this is only a read, for consistency.


err = requiredFields(REQUIRED_TYPE_FIELDS, request.TypeName)
response := &proto.GetArtifactTypeResponse{}

var results []db.Type
rx := dbConn.Find(&results, db.Type{Name: *request.TypeName, TypeKind: int32(ARTIFACT_TYPE), Version: request.TypeVersion})
if rx.Error != nil {
return nil, rx.Error
}
if len(results) > 1 {
return nil, fmt.Errorf("more than one type found: %v", len(results))
}
if len(results) == 0 {
return response, nil
}

r0 := results[0]
artifactType := proto.ArtifactType{
Id: &r0.ID,
Name: &r0.Name,
Version: r0.Version,
Description: r0.Description,
ExternalId: r0.ExternalID,
}
for _, v := range r0.Properties {
artifactType.Properties[v.Name] = proto.PropertyType(v.DataType)
}
response.ArtifactType = &artifactType
return response, nil
}

func (g grpcServer) GetArtifactTypesByID(ctx context.Context, request *proto.GetArtifactTypesByIDRequest) (*proto.GetArtifactTypesByIDResponse, error) {
Expand Down
6 changes: 6 additions & 0 deletions test/python/test_mlmetadata.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,12 @@ def main():
response = store.PutArtifactType(request)
model_type_id = response.type_id

request = metadata_store_service_pb2.GetArtifactTypeRequest()
request.type_name = "SavedModel"
response = store.GetArtifactType(request)
assert response.artifact_type.id == 2
assert response.artifact_type.name == "SavedModel"

# Query all registered Artifact types.
# artifact_types = store.GetArtifactTypes()

Expand Down