Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat! Dropping Sass support from builtin LTI block #35769

Merged
merged 5 commits into from
Nov 5, 2024
Merged

feat! Dropping Sass support from builtin LTI block #35769

merged 5 commits into from
Nov 5, 2024

Conversation

ttqureshi
Copy link
Contributor

Dropping Sass Support from Built-in LTI Block

Tickets: #35570

Tasks:

  • Convert Sass variable into css variables
  • Compile the css files of the block following below steps.
    • Change this line to the following to avoid adding comments in the compiled css files. This change is only for compilation, revert it when done with compilation. 
      source_comments: int = SASS_COMMENTS_NONE
    • Compile the sass to uncompressed CSS using following command 
      npm run compile-sass-dev
    • Copy the compiled XBlock linked CSS (lms/static/css/*Display.css) into xmodule/static/css-builtin-blocks.
    • Format the CSS files using the editor.
    • Add those CSS files to version control.
  • Replace add_sass_to_fragment to add_css_to_fragment in lti_block.py file
  • Remove all .scss files linked to the block under xmodule/assets.
    • Make sure to remove the .scss file in a separate alone commit so reviewer could review scss changes and they stay in history.
    • Don't remove the scss file if its linked to some other block.

Testing

  • Run npm run build to run webpack and compile sass files.
  • Run ./manage.py lms collectstatic in lms shell to re-collect static files.
  • Run ./manage.py cms collectstatic in cms shell to re-collect static files.
  • Verify the block's compiled css and the css global variables in the LMS.
  • Verify the block's compiled css and the css global variables in the Studio.
  • Test the XBlock rendering and User Experience in LMS.
  • Test the XBlock rendering and User Experience in Studio.

Screenshots

image image image image

@farhan
Copy link
Contributor

farhan commented Nov 5, 2024

Looks good to me, let the tests pass

@farhan farhan self-requested a review November 5, 2024 12:25
@farhan farhan merged commit b7d08fb into openedx:master Nov 5, 2024
49 checks passed
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

1 similar comment
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

1 similar comment
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

1 similar comment
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

@ttqureshi ttqureshi deleted the ttqureshi/sass-to-css-lti-block branch November 6, 2024 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@farhan farhan farhan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ttqureshi @farhan @edx-pipeline-bot