Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat! Dropping Sass support from builtin LTI block #35769

Merged
merged 5 commits into from
Nov 5, 2024
Merged

feat! Dropping Sass support from builtin LTI block #35769

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5dec4ee
feat: Dropping Sass support from builtin LTI block
ttqureshi Oct 7, 2024
8883dac
build: Compile css file of LTI block
ttqureshi Oct 7, 2024
8732071
chore: Remove scss files
ttqureshi Oct 7, 2024
d5192c5
fix: ValueError - css_file_name should be .css file
ttqureshi Oct 7, 2024
b0ad205
chore: add extra line at the end of file
ttqureshi Oct 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions xmodule/assets/LTIBlockDisplay.scss
View file
Open in desktop

This file was deleted.

65 changes: 0 additions & 65 deletions xmodule/assets/lti/_lti.scss
View file
Open in desktop

This file was deleted.

4 changes: 2 additions & 2 deletions xmodule/lti_block.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@
)
from xmodule.lti_2_util import LTI20BlockMixin, LTIError
from xmodule.raw_block import EmptyDataRawMixin
from xmodule.util.builtin_assets import add_webpack_js_to_fragment, add_sass_to_fragment
from xmodule.util.builtin_assets import add_webpack_js_to_fragment, add_css_to_fragment
from xmodule.xml_block import XmlMixin
from xmodule.x_module import (
ResourceTemplates,
Expand Down Expand Up @@ -524,7 +524,7 @@ def student_view(self, _context):
"""
fragment = Fragment()
fragment.add_content(self.runtime.service(self, 'mako').render_lms_template('lti.html', self.get_context()))
add_sass_to_fragment(fragment, 'LTIBlockDisplay.scss')
add_css_to_fragment(fragment, 'LTIBlockDisplay.css')
add_webpack_js_to_fragment(fragment, 'LTIBlockDisplay')
shim_xmodule_js(fragment, 'LTI')
return fragment
Expand Down
62 changes: 62 additions & 0 deletions xmodule/static/css-builtin-blocks/LTIBlockDisplay.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,62 @@
@import url("https://fonts.googleapis.com/css?family=Open+Sans:300,400,400i,600,700");

.xmodule_display.xmodule_LTIBlock {
/* stylelint-disable-line */
/* stylelint-disable-line */
/* stylelint-disable-line */
/* stylelint-disable-line */
}

.xmodule_display.xmodule_LTIBlock h2.problem-header {
display: inline-block;
}

.xmodule_display.xmodule_LTIBlock div.problem-progress {
display: inline-block;
padding-left: calc((var(--baseline)/4));
color: #666;
font-weight: 100;
font-size: 1em;
}

.xmodule_display.xmodule_LTIBlock div.lti {
margin: 0 auto;
}

.xmodule_display.xmodule_LTIBlock div.lti .wrapper-lti-link {
font-size: 14px;
background-color: var(--sidebar-color);
padding: var(--baseline);
}

.xmodule_display.xmodule_LTIBlock div.lti .wrapper-lti-link .lti-link {
margin-bottom: 0;
text-align: right;
}

.xmodule_display.xmodule_LTIBlock div.lti .wrapper-lti-link .lti-link .link_lti_new_window {
font-size: 13px;
line-height: 20.72px;
}

.xmodule_display.xmodule_LTIBlock div.lti form.ltiLaunchForm {
display: none;
}

.xmodule_display.xmodule_LTIBlock div.lti iframe.ltiLaunchFrame {
width: 100%;
height: 800px;
display: block;
border: 0px;
}

.xmodule_display.xmodule_LTIBlock div.lti h4.problem-feedback-label {
font-weight: 100;
font-size: 1em;
font-family: "Source Sans", "Open Sans", Verdana, Geneva, sans-serif, sans-serif;
}

.xmodule_display.xmodule_LTIBlock div.lti div.problem-feedback {
margin-top: calc((var(--baseline)/4));
margin-bottom: calc((var(--baseline)/4));
}
Loading