fix: compute normalized_metadata.enroll_by_date in enterprise-canonical fashion #909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…al fashion * Take the seat `upgrade_deadline_override` into account, and prefer it over `upgrade_deadline`. * Prefer the course run's `enrollment_end` for exec ed 2u courses (over legacy `registration_deadline`). * Prefer the course run's `enrollment_end` for other course types when no advertised course run seat exists (or if the seat has no upgrade deadline). ENT-7472
This was referenced Aug 14, 2024
Merged
pwnage101
approved these changes
Aug 14, 2024
Comment on lines
130
to
+136
| if not self.advertised_course_run: | ||
| return None | ||
|
|
||
| if obj.is_exec_ed_2u_course: | ||
| return ( | ||
| self.advertised_course_run.get('enrollment_end') | ||
| or self.additional_metadata.get('registration_deadline') |
There was a problem hiding this comment.
Do you know if we might have a course with no advertised run, but a populated additional_metadata section?
There was a problem hiding this comment.
Hmm, I'm not sure - but in that case, maybe it's valid to assert that the enroll_by_date is null?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
upgrade_deadline_overrideinto account, and prefer it overupgrade_deadline.enrollment_endfor exec ed 2u courses (over legacyregistration_deadline).enrollment_endfor other course types when no advertised course run seat exists (or if the seat has no upgrade deadline).ENT-7472
Post-review