Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: test problems jest dom and paragon #311

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

johnvente
Copy link
Contributor

@johnvente johnvente commented Jan 31, 2024

Description

Currently, after running "npm run test", tests will fail due to an update of @testing-library/jest-dom to v6.0.0, which has a breaking change that removes the import of @testing-library/jest-dom/extend-expect. After fixing that, you will encounter a problem with @openedx/paragon. With this fix, the tests will run properly.

Issue: #310

Screen Shot 2024-01-31 at 11 13 05 AM

How to tes it

git fetch origin pull/311/head:jv/fix-test-problems
git checkout jv/fix-test-problems
npm run test

@openedx-webhooks
Copy link

Thanks for the pull request, @johnvente! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jan 31, 2024
Copy link

codecov bot commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9f1c950) 100.00% compared to head (a5c0e17) 100.00%.
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #311   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          110       110           
  Lines         1079      1079           
  Branches       159       159           
=========================================
  Hits          1079      1079           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brian-smith-tcril brian-smith-tcril merged commit 44d6dc6 into openedx:master Feb 2, 2024
6 checks passed
@openedx-webhooks
Copy link

@johnvente 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants