fix: a bug when Discover and Program screens appear not in the middle #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
volodymyr-chekyrta
previously approved these changes
Mar 25, 2024
There was a problem hiding this comment.
@dixidroid great work overall. Can we please update the CourseInfoFragment as well? It's also part of the Discovery feature.
dixidroid
force-pushed
the
fix/discover_program_tablet_issue
branch
from
1ab63d7 to
8dcd4d3
Compare
|
The CourseInfo screen is still at the start: 
|
dixidroid
force-pushed
the
fix/discover_program_tablet_issue
branch
from
8dcd4d3 to
2c65d82
Compare
dixidroid
force-pushed
the
fix/discover_program_tablet_issue
branch
from
2c65d82 to
a445192
Compare
HamzaIsrar12
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discover, Program and Explore all courses screens now appear in the middle on tablets