-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HLS video quality #76
HLS video quality #76
Conversation
# Conflicts: # app/src/main/AndroidManifest.xml # course/src/main/java/org/openedx/course/presentation/unit/container/CourseUnitContainerFragment.kt # course/src/main/java/org/openedx/course/presentation/unit/video/VideoUnitFragment.kt
# Conflicts: # course/src/main/java/org/openedx/course/presentation/unit/container/CourseUnitContainerFragment.kt
Thanks for the pull request, @PavloNetrebchuk! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
…ure/video_quality
d3ebf0c
to
889d660
Compare
# Conflicts: # app/src/main/java/org/openedx/app/di/ScreenModule.kt # course/build.gradle # course/src/main/java/org/openedx/course/presentation/unit/video/EncodedVideoUnitViewModel.kt # course/src/main/java/org/openedx/course/presentation/unit/video/VideoUnitFragment.kt
I think this is an area where the engineering is a bit ahead of our design efforts, but this looks good to me based on the existing designs. iOS/Android video quality language should match. I think it should be "Lower data usage," or something similar. For comparison, YouTube uses "Lower picture quality" for lowest-quality, and "Uses more data" for highest-quality. For downloads, the current EdX app uses "Smallest file size" for lowest-quality, and "Best quality" for highest-quality for mobile video downloads. (Similar comment also posted on openedx/openedx-app-ios#134) |
5532eaf
to
36b8a7b
Compare
36b8a7b
to
a71e0c1
Compare
# Conflicts: # course/src/main/java/org/openedx/course/presentation/unit/video/VideoUnitFragment.kt
@PavloNetrebchuk 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Setting the HLS video quality value selected in the settings