-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add HLS quality support #134
Add HLS quality support #134
Conversation
IvanStepanok
commented
Oct 25, 2023
•
edited
Loading
edited
Thanks for the pull request, @IvanStepanok! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
I think this is an area where the engineering is a bit ahead of our design efforts, but this looks good to me based on the existing designs. iOS/Android video quality language should match. I think it should be "Lower data usage," or something similar. For comparison, YouTube uses "Lower picture quality" for lowest-quality, and "Uses more data" for highest-quality. For downloads, the current EdX app uses "Smallest file size" for lowest-quality, and "Best quality" for highest-quality for mobile video downloads. (Similar comment also posted on openedx/openedx-app-android#76) |
@IvanStepanok 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |