Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HLS quality support #134

Merged

Conversation

IvanStepanok
Copy link
Contributor

@IvanStepanok IvanStepanok commented Oct 25, 2023

720p
360p

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 25, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented Oct 25, 2023

Thanks for the pull request, @IvanStepanok! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@sdaitzman
Copy link

I think this is an area where the engineering is a bit ahead of our design efforts, but this looks good to me based on the existing designs. iOS/Android video quality language should match. I think it should be "Lower data usage," or something similar.

For comparison, YouTube uses "Lower picture quality" for lowest-quality, and "Uses more data" for highest-quality. For downloads, the current EdX app uses "Smallest file size" for lowest-quality, and "Best quality" for highest-quality for mobile video downloads.

(Similar comment also posted on openedx/openedx-app-android#76)

@volodymyr-chekyrta volodymyr-chekyrta merged commit ab942a4 into openedx:develop Nov 6, 2023
1 check passed
@openedx-webhooks
Copy link

@IvanStepanok 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@volodymyr-chekyrta volodymyr-chekyrta deleted the feature/add-hls-support branch November 6, 2023 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

HLS support in video player and video streaming quality settings
5 participants