Fix/modify mv routing test #295
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed_grid fixture, needs to be filled in with the relevant asserts
|
|
@santiagoinfantinom can I discuss current state of this PR with you in person? |
|
Closed due to major changes, but mentioned in #377 to keep the work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not Ready to merge.
This was an improvement to the existing mv grids' routing test. The existing test case used the example grid and draws all the information that it needs from oep. The test case that is written here creates an artificial ding0 grid, to check that each and every connection made during the routing for both the connection points, the positioning of the ciricutbreaker and the thickness of the lines.
Current state of this branch is:
The pytest fixture creating the test grid is complete. The test case's assert to check each and every edge created seems to pass and fail at random. The randomness is induced by the naming /order of the mv circuitbreakers that are created during routing. Once the assert statement is crafted such that the order of the circuit-breakers can be deterministically obtained, this branch should work properly.