Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review by records instead of subject_id & form_id "rv_row" #137

Open
wants to merge 36 commits into
base: dev
Choose a base branch
from
Open

Review by records instead of subject_id & form_id "rv_row" #137

wants to merge 36 commits into from

Commits on Nov 13, 2024

  1. Migrate to review_records from review_row

    @jthompson-arcus
    jthompson-arcus committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    7c58504 View commit details
    Browse the repository at this point in the history

  2. Update test-fct_SQLite.R

    @jthompson-arcus
    jthompson-arcus committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    b271add View commit details
    Browse the repository at this point in the history

  3. Update test-mod_review_forms.R

    @jthompson-arcus
    jthompson-arcus committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    39d8da1 View commit details
    Browse the repository at this point in the history

  4. Update test-mod_main_sidebar.R

    @jthompson-arcus
    jthompson-arcus committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    43931ed View commit details
    Browse the repository at this point in the history

  5. Fix R CMD checks

    @jthompson-arcus
    jthompson-arcus committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    d311ab1 View commit details
    Browse the repository at this point in the history

  6. Fix db_get_review() example

    @jthompson-arcus
    jthompson-arcus committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    ccd9bb1 View commit details
    Browse the repository at this point in the history

  7. Helps if you update documentation

    @jthompson-arcus
    jthompson-arcus committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    0743880 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2024

  1. Only UPDATE reviews when review status is changed

    @jthompson-arcus
    jthompson-arcus committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    e5e8acb View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2024

  1. Resolve merge conflicts with jt-113-simplify_review_process 

    Merge branch 'jt-113-simplify_review_process' into jt-99-review_by_row

# Conflicts:
#	R/fct_SQLite.R
#	man/db_save_review.Rd
#	tests/testthat/test-fct_SQLite.R
#	tests/testthat/test-mod_review_forms.R
    @jthompson-arcus
    jthompson-arcus committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    2551970 View commit details
    Browse the repository at this point in the history

  2. Keep current structure for enabling reviews

    @jthompson-arcus
    jthompson-arcus committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    d863300 View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2024

  1. Resolve merge conflict with dev 

    Merge branch 'dev' into jt-99-review_by_row

# Conflicts:
#	R/mod_review_forms.R
#	tests/testthat/test-mod_review_forms.R
    @jthompson-arcus
    jthompson-arcus committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    6ad27a6 View commit details
    Browse the repository at this point in the history

  2. Generalize db_get_review()

    @jthompson-arcus
    jthompson-arcus committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    a23b462 View commit details
    Browse the repository at this point in the history

  3. Update version and NEWS

    @jthompson-arcus
    jthompson-arcus committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    6990cf1 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2024

  1. Update scenario description for two rows

    @jthompson-arcus
    jthompson-arcus committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    3db4274 View commit details
    Browse the repository at this point in the history

  2. Update language from row to records

    @jthompson-arcus
    jthompson-arcus committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    1c675a9 View commit details
    Browse the repository at this point in the history

  3. Grab un-duplicated rv_records

    @jthompson-arcus
    jthompson-arcus committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    c177a30 View commit details
    Browse the repository at this point in the history

  4. Remove unnecessary dplyr::select()

    @jthompson-arcus
    jthompson-arcus committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    d2fa0d6 View commit details
    Browse the repository at this point in the history

  5. Remove unneeded dplyr::distinct()

    @jthompson-arcus
    jthompson-arcus committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    de24777 View commit details
    Browse the repository at this point in the history

  6. Return db_get_review() when ... is empty

    @jthompson-arcus
    jthompson-arcus committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    d372afa View commit details
    Browse the repository at this point in the history

  7. Update test-mod_review_forms.R

    @jthompson-arcus
    jthompson-arcus committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    f28f174 View commit details
    Browse the repository at this point in the history

  8. Update only one table in db_save_review()

    @jthompson-arcus
    jthompson-arcus committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    7e26f83 View commit details
    Browse the repository at this point in the history

  9. Fix oopsies

    @jthompson-arcus
    jthompson-arcus committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    ad3f05e View commit details
    Browse the repository at this point in the history

  10. Fix merge conflict with dev 

    Merge branch 'dev' into jt-99-review_by_row

# Conflicts:
#	DESCRIPTION
#	inst/golem-config.yml
    @jthompson-arcus
    jthompson-arcus committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    939566f View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2024

  1. Add test for db_get_review() when no filters are specified

    @jthompson-arcus
    jthompson-arcus committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    439d14b View commit details
    Browse the repository at this point in the history

  2. Fix updated_items_memory

    @jthompson-arcus
    jthompson-arcus committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    0079348 View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2024

  1. Don't export db_get_review anymore

    @LDSamson
    LDSamson committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    ca83997 View commit details
    Browse the repository at this point in the history

  2. Update documentation

    @LDSamson
    LDSamson committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    0f680cd View commit details
    Browse the repository at this point in the history

  3. Ensure db_get_review errors before sending a db query if ... cannot… 

    … be coerced to a data frame
    @LDSamson
    LDSamson committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    a08c510 View commit details
    Browse the repository at this point in the history

  4. Add additional tests

    @LDSamson
    LDSamson committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    f7ba04a View commit details
    Browse the repository at this point in the history

  5. Use more consistent naming in the save review process

    @LDSamson
    LDSamson committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    205896f View commit details
    Browse the repository at this point in the history

  6. Change a dplyr::filter call to base R filter for performance reasons

    @LDSamson
    LDSamson committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    b8f3f52 View commit details
    Browse the repository at this point in the history

  7. Ensure that updated_records_memory has the same columns as in the db

    @LDSamson
    LDSamson committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    0154355 View commit details
    Browse the repository at this point in the history

  8. Ensure tests will fail if there is a review discrepancy

    @LDSamson
    LDSamson committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    f0144a2 View commit details
    Browse the repository at this point in the history

  9. Export review_save_error to ensure errors are captured when saving re… 

    …view in in a shinytest2 test
    @LDSamson
    LDSamson committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    5360760 View commit details
    Browse the repository at this point in the history

  10. Update snaps

    @LDSamson
    LDSamson committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    88f5b04 View commit details
    Browse the repository at this point in the history

  11. Also update mod_main_sidebar snaps

    @LDSamson
    LDSamson committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    23b6e91 View commit details
    Browse the repository at this point in the history