Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: remove http2 hardcode limitation in ngx.location subrequest API #2355

Conversation

oowl
Copy link
Contributor

@oowl oowl commented Sep 4, 2024

I hereby granted the copyright of the changes in this pull request
to the authors of this lua-nginx-module project.

context: #2243

@oowl oowl changed the title fix: remove http2 hardcode limitation in ngx.location subrequest API bugfix: remove http2 hardcode limitation in ngx.location subrequest API Sep 4, 2024
@oowl oowl changed the title bugfix: remove http2 hardcode limitation in ngx.location subrequest API bugfix: remove http2 hardcode limitation in ngx.location subrequest API Sep 4, 2024
@zhuizhuhaomeng
Copy link
Contributor

@oowl would you please add some test cases to cover this change.

@oowl
Copy link
Contributor Author

oowl commented Sep 6, 2024

Yeah, i will. please wait for me running huge kong side integration test to verify http2 location capture case problem.

@zhuizhuhaomeng
Copy link
Contributor

@oowl any progress?

Copy link

mergify bot commented Oct 24, 2024

This pull request is now in conflict :(

@mergify mergify bot added the conflict label Oct 24, 2024
@oowl oowl force-pushed the remove-http2-hardcode-limitation-in-ngx-location branch from 922d15a to 0abcb20 Compare October 24, 2024 06:04
@mergify mergify bot removed the conflict label Oct 24, 2024
@oowl
Copy link
Contributor Author

oowl commented Oct 24, 2024

@zhuizhuhaomeng Hi, I have been enable all http2 test in ci config. Can you help me take a look?
Note: Some test can not execute in http2 mode, so i disable it by --- no_http2 config command for skip http2 test.

@oowl
Copy link
Contributor Author

oowl commented Oct 24, 2024

sister PR: openresty/test-nginx#176

@zhuizhuhaomeng zhuizhuhaomeng merged commit 950b1fb into openresty:master Nov 6, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants