Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.markdown #43

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update README.markdown #43

wants to merge 1 commit into from

Conversation

jzh800
Copy link

@jzh800 jzh800 commented Apr 25, 2017

if you turn on it,
lua_code_cache off;
the status page will report (NO checkers) ,
so modify the readme

@@ -152,7 +152,7 @@ Upstream bar.com
127.0.0.1:12356 up
```

If an upstream has no health checkers, then it will be marked by `(NO checkers)`, as in
If you turn on lua_code_cache off or an upstream has no health checkers, then it will be marked by `(NO checkers)`, as in
Copy link
Member

@agentzh agentzh Apr 25, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should document the behavior of lua_code_cache off here. It was for dirty and quick development for individual nginx requests only. anything that need to span multiple nginx requests (like timers, cosocket connection pools, semaphores) won't work anyway in lua_code_cache off.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nobody, ever, should use lua_code_cache off in production. That will make OpenResty much slower than even Apache and PHP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants