Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.markdown #43

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update README.markdown #43

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.markdown
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ Upstream bar.com
127.0.0.1:12356 up
```

If an upstream has no health checkers, then it will be marked by `(NO checkers)`, as in
If you turn on lua_code_cache off or an upstream has no health checkers, then it will be marked by `(NO checkers)`, as in
Copy link
Member

@agentzh agentzh Apr 25, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should document the behavior of lua_code_cache off here. It was for dirty and quick development for individual nginx requests only. anything that need to span multiple nginx requests (like timers, cosocket connection pools, semaphores) won't work anyway in lua_code_cache off.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nobody, ever, should use lua_code_cache off in production. That will make OpenResty much slower than even Apache and PHP.


```
Upstream foo.com (NO checkers)
Expand Down