Star Tree Search changes related to new Aggregations supported #9163
Conversation
Adding example for star-tree supported date histogram as it is supported in OpenSearch 2.19 Signed-off-by: Sandesh Kumar <[email protected]>
sandeshkr419
requested review from
kolchfa-aws,
Naarcha-AWS,
AMoo-Miki,
natebower,
dlvenable and
epugh
as code owners
|
Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged. Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer. When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review. |
Add queries included in 2.19 Signed-off-by: Sandesh Kumar <[email protected]>
kolchfa-aws
added
release-notes
sandeshkr419
changed the title
Signed-off-by: Sandesh Kumar <[email protected]>
_search-plugins/star-tree-index.md
Outdated
| { | ||
| "query": { | ||
| "term": { | ||
| "status": "500" |
There was a problem hiding this comment.
Can we use range query or keyword term query since term is already used in the above example ? Maybe keyword term query will be a good example.
There was a problem hiding this comment.
@bharath-techie: I'll update the example to use a range query.
Signed-off-by: bharath-techie <[email protected]>
Signed-off-by: Naarcha-AWS <[email protected]>
Naarcha-AWS
added
4 - Doc review
Signed-off-by: Naarcha-AWS <[email protected]>
Signed-off-by: Naarcha-AWS <[email protected]>
There was a problem hiding this comment.
Before we can pass this to editorial review, there's one review comment from @expani that still needs to be address and a follow-up question from me.
Signed-off-by: Sandesh Kumar <[email protected]>
Signed-off-by: Sandesh Kumar <[email protected]>
|
Thanks @Naarcha-AWS for the comments, addressed them all now. Let me know if there are further actions. |
Signed-off-by: Naarcha-AWS <[email protected]>
Signed-off-by: Naarcha-AWS <[email protected]>
| - `keyword` | ||
| - `object` | ||
| - `date` which can use up to three of following calendar intervals: | ||
| - `year` (of era) |
There was a problem hiding this comment.
What do we mean by "of blank"?
There was a problem hiding this comment.
The fields names are what defined inside "". Extra clarification is just for information. Usually month, year etc are understood easily, but certain fields like week` needed extra clarification like (week of week based year)
Signed-off-by: Sandesh Kumar <[email protected]>
Signed-off-by: Sandesh Kumar <[email protected]>
| ```json | ||
| POST /logs/_search | ||
| { | ||
| "query": { |
There was a problem hiding this comment.
Is this a valid query ? @sandeshkr419 just double checking. I don't see term/terms etc
There was a problem hiding this comment.
@bharath-techie: I updated the query to add terms while keeping the method.
There was a problem hiding this comment.
This is still not a valid query , we don't support range on timestamp. Lets reword this @Naarcha-AWS
There was a problem hiding this comment.
@bharath-techie: Can you suggest a valid query?
Naarcha-AWS
added
5 - Editorial review
Signed-off-by: Naarcha-AWS <[email protected]>
|
@natebower: This is ready for editorial review. |
There was a problem hiding this comment.
@Naarcha-AWS Please see my comments and changes and reply to my tags when addressed and ready for approval. Thanks!
Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Naarcha-AWS <[email protected]>
Signed-off-by: Naarcha-AWS <[email protected]>
Signed-off-by: Naarcha-AWS <[email protected]>
Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Naarcha-AWS <[email protected]>
Adding example for star-tree supported date histogram as it is supported in OpenSearch 2.19
Description
Adds details about following features added in 2.19
PRs with feature inclusions:
opensearch-project/OpenSearch#17137
opensearch-project/OpenSearch#16674
Project Meta: opensearch-project/OpenSearch#15257
Issues Resolved
Closes #[delete this text, including the brackets, and replace with the issue number]
Version
OpenSearch 2.19 and above
Frontend features
If you're submitting documentation for an OpenSearch Dashboards feature, add a video that shows how a user will interact with the UI step by step. A voiceover is optional.
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.