Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Star Tree Search changes related to new Aggregations supported #9163
Star Tree Search changes related to new Aggregations supported #9163
Changes from 7 commits
318915e
1a02f55
5280adb
4fbe03c
4a9d099
1cf92e2
01ba392
95fea9b
7a6a90c
ac157a1
f97a7d1
d393211
274c8a4
365aed0
1c359fd
3323395
f6eae46
6777e85
1be0ba4
531e498
a12edfc
655fce5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check failure on line 158 in _search-plugins/star-tree-index.md
Check failure on line 162 in _search-plugins/star-tree-index.md
Check warning on line 171 in _search-plugins/star-tree-index.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a valid query ? @sandeshkr419 just double checking. I don't see term/terms etc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bharath-techie: I updated the query to add terms while keeping the method.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is still not a valid query , we don't support range on timestamp. Lets reword this @Naarcha-AWS
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bharath-techie: Can you suggest a valid query?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use range query or keyword term query since term is already used in the above example ? Maybe keyword term query will be a good example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bharath-techie: I'll update the example to use a range query.