Add queryInsightsDashboards to 2.19, 3.0, 3.0.0-alpha1 dashboard test manifests #5273
+22
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dzane17
requested review from
dblock,
peterzhuamazon,
gaiksaya,
rishabh6788,
zelinh,
prudhvigodithi,
Divyaasm and
tianleh
as code owners
ansjcy
approved these changes
Jan 28, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5273 +/- ##
=======================================
Coverage 92.06% 92.06%
=======================================
Files 202 202
Lines 7017 7017
=======================================
Hits 6460 6460
Misses 557 557 ☔ View full report in Codecov by Sentry. |
peterzhuamazon
requested changes
Jan 28, 2025
There was a problem hiding this comment.
Hi @dzane17 please add the 3.0.0 potion to 3.0.0-alpha1 related manifests.
The original 3.0.0 will reserve for GA.
We will copy paste the future 3.0.0-beta1 to 3.0.0 later. Thanks.
Signed-off-by: David Zane <[email protected]>
|
@peterzhuamazon I have added to |
dzane17
changed the title
Signed-off-by: David Zane <[email protected]>
23 tasks
gaiksaya
approved these changes
Jan 29, 2025
You can keep it for now, we will copy paste from beta1 anyway later on. |
peterzhuamazon
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
queryInsightsDashboardsto 2.19 , 3.0, 3.0.0-alpha1 dashboard test manifestsquery-insights-dashboardsto release issues listIssues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.