OCPBUGS-44953: don't set current clients when no OIDC providers are configured

[everettraven]

Description

Fixes OCPBUGS-44953 by resetting the AuthStatusHandler.currentClientID to an empty string when the Authentication.Spec.Type is not set to OIDC.

Additionally, protects against a degraded state when AuthStatusHandler.currentClientID is set but there is no evidence of OIDC providers being configured in the spec by only adding current clients in the Authentication status when both the currentClientID is set and there is evidence of OIDC providers being configured.

Adds a warning log when we notice the currentClientID is set but there is no evidence of OIDC providers being configured.

[openshift-ci-robot]

@everettraven: This pull request references Jira Issue OCPBUGS-44953, which is invalid:

• expected the bug to target the "4.19.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Description

Fixes OCPBUGS-44953 by resetting the AuthStatusHandler.currentClientID to an empty string when the Authentication.Spec.Type is not set to OIDC.

Additionally, protects against a degraded state when AuthStatusHandler.currentClientID is set but there is no evidence of OIDC providers being configured in the spec by only adding current clients in the Authentication status when both the currentClientID is set and there is evidence of OIDC providers being configured.

Adds a warning log when we notice the currentClientID is set but there is no evidence of OIDC providers being configured.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[everettraven]

/jira refresh

[openshift-ci-robot]

@everettraven: This pull request references Jira Issue OCPBUGS-44953, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.19.0) matches configured target version for branch (4.19.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yapei

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[xingxingxia]

Pre-merge tested, issue is fixed. Results are commented in Jira bug.
/label qe-approved

[openshift-ci-robot]

@everettraven: This pull request references Jira Issue OCPBUGS-44953, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.19.0) matches configured target version for branch (4.19.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @xingxingxia

In response to this:

Description

Fixes OCPBUGS-44953 by resetting the AuthStatusHandler.currentClientID to an empty string when the Authentication.Spec.Type is not set to OIDC.

Additionally, protects against a degraded state when AuthStatusHandler.currentClientID is set but there is no evidence of OIDC providers being configured in the spec by only adding current clients in the Authentication status when both the currentClientID is set and there is evidence of OIDC providers being configured.

Adds a warning log when we notice the currentClientID is set but there is no evidence of OIDC providers being configured.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[jhadvig]

/lgtm
/approve
/retest

@everettraven how far do we need to backport this change ?

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: everettraven, jhadvig

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jhadvig]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[everettraven]

@jhadvig I believe just to 4.18 since that is the target for the external OIDC feature, but I'll sync up with @liouk when he is back from PTO to verify

[openshift-ci]

@everettraven: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci-robot]

@everettraven: Jira Issue OCPBUGS-44953: All pull requests linked via external trackers have merged:

• openshift/console-operator#945

Jira Issue OCPBUGS-44953 has been moved to the MODIFIED state.

In response to this:

Description

Fixes OCPBUGS-44953 by resetting the AuthStatusHandler.currentClientID to an empty string when the Authentication.Spec.Type is not set to OIDC.

Additionally, protects against a degraded state when AuthStatusHandler.currentClientID is set but there is no evidence of OIDC providers being configured in the spec by only adding current clients in the Authentication status when both the currentClientID is set and there is evidence of OIDC providers being configured.

Adds a warning log when we notice the currentClientID is set but there is no evidence of OIDC providers being configured.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-bot]

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-console-operator
This PR has been included in build openshift-enterprise-console-operator-container-v4.19.0-202412061937.p0.g5e4acb1.assembly.stream.el9.
All builds following this will include this PR.

[xingxingxia]

Yes, only need backport for 4.18
/cherry-pick release-4.18

[openshift-cherrypick-robot]

@xingxingxia: new pull request created: #948

In response to this:

Yes, only need backport for 4.18
/cherry-pick release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.