ODC-7721: Disable developer perspective by default #954
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@Lucifergene: This pull request references ODC-7721 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Lucifergene The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cc @jhadvig @TheRealJon |
|
I suspect we're need to make a lot of Cypress test updates before we can merge this since many tests switch to the dev perspective. |
Yes, we need to update ODC cypress tests otherwise it will break the CI. Here is the story for it ODC-7718 we will get this in first. |
Signed-off-by: Lucifergene <[email protected]>
Lucifergene
force-pushed
the
disable-dev-perspective-by-default
branch
from
5388256 to
cfe12f9
Compare
|
@Lucifergene: This pull request references ODC-7721 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Thanks @Lucifergene |
Signed-off-by: Lucifergene <[email protected]>
|
/label tide/merge-method-squash |
openshift-ci
bot
added
tide/merge-method-squash
|
/retest |
|
/test e2e-aws-console |
|
/test e2e-aws-console |
|
/retest |
1 similar comment
|
/retest |
|
@Lucifergene: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Note: No need to run retests on the failing ones. |
There was a problem hiding this comment.
@Lucifergene Any thoughts on how to approach updating the e2e tests in the console repo? Maybe a good first step is to update the tests to use the admin perspective for any nav items that are now exposed there.
| @@ -500,6 +500,16 @@ func (b *ConsoleServerCLIConfigBuilder) customization() Customization { | |||
| } | |||
| } | |||
|
|
|||
| conf.Perspectives = perspectives | |||
There was a problem hiding this comment.
Let's add a unit test that confirms that the dev perspective is not disabled when there is any perspective config.
There was a problem hiding this comment.
I wonder if this is a little odd since if I add a config to customize perspective foo it could also enable the dev perspective when it was disabled before because there was no config. We might want to change the logic here to only enable the dev perspective if the admin perspective is disabled (or disabled for at least some users due to an access review check).
What do you guys think?
There was a problem hiding this comment.
Agree, we should only enable the dev perspective.
|
Hi @spadgett, regarding the e2e tests, @sanketpathak is working on updating the e2e tests. Here is the Jira ticket ODC-7718 and PR openshift/console#14684 |
Jira: https://issues.redhat.com/browse/ODC-7721
This pull request introduces changes to manage the visibility of different perspectives in the console server configuration. The changes include adding a new type for perspective IDs, updating the configuration builder to handle perspective visibility, and modifying the operator configuration manifest.
Changes to perspective management:
pkg/console/subresource/consoleserver/types.go: AddedPerspectiveIDtype and constants for admin and developer perspectives.Configuration updates:
pkg/console/subresource/consoleserver/config_builder.go: Modified thecustomizationfunction to include perspective visibility settings and disable the developer perspective by default.manifests/01-operator-config.yaml: Added configuration for perspectives, setting the developer perspective to be disabled by default.