Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ODC-7735: Edit ci tests to have step to enable developer perspective #14684

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

ODC-7735: Edit ci tests to have step to enable developer perspective #14684

wants to merge 1 commit into from

Conversation

sanketpathak
Copy link
Contributor

@sanketpathak sanketpathak commented Jan 16, 2025 •
edited
Loading

@openshift-ci openshift-ci bot requested review from ppitonak and The-Anton January 16, 2025 07:40
@openshift-ci openshift-ci bot added the component/dev-console Related to dev-console label Jan 16, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 16, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sanketpathak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added component/helm Related to helm-plugin approved Indicates a PR has been approved by an approver from all required OWNERS files. component/knative Related to knative-plugin component/pipelines Related to pipelines-plugin component/topology Related to topology labels Jan 16, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 16, 2025

@sanketpathak: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-console 0268001 link true /test e2e-gcp-console

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@sanketpathak sanketpathak changed the title Edit ci tests to have step to enable developer perspective ODC-7735: Edit ci tests to have step to enable developer perspective Jan 16, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 16, 2025 •
edited by openshift-ci bot
Loading

@sanketpathak: This pull request references ODC-7735 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.19.0" version, but no target version was set.

In response to this:

Issue: https://issues.redhat.com/browse/ODC-7735

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 16, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 16, 2025 •
edited by openshift-ci bot
Loading

@sanketpathak: This pull request references ODC-7735 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.19.0" version, but no target version was set.

In response to this:

Issue: https://issues.redhat.com/browse/ODC-7718

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@vikram-raj vikram-raj mentioned this pull request Jan 20, 2025
Open
spadgett
spadgett requested changes Jan 20, 2025
View reviewed changes
frontend/packages/dev-console/integration-tests/support/commands/hooks.ts
@@ -19,7 +20,14 @@ before(() => {
const bridgePasswordPassword: string = Cypress.env('BRIDGE_HTPASSWD_PASSWORD') || 'test';
cy.login(bridgePasswordIDP, bridgePasswordUsername, bridgePasswordPassword);
cy.document().its('readyState').should('eq', 'complete');
cy.exec(
`oc patch console.operator.openshift.io/cluster --type='merge' -p '{"spec":{"customization":{"perspectives":[{"id":"dev","visibility":{"state":"Enabled"}}]}}}'`,
{ failOnNonZeroExit: false },
Copy link
Member

@spadgett spadgett Jan 20, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why wouldn't we fail on non-zero codes?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was used for the case that each package(ODC) will be using this patch so to avoid any issue I used this, I'll update it

.../packages/dev-console/integration-tests/support/pages/functions/checkDeveloperPerspective.ts
Comment on lines +10 to +12
cy.reload();
cy.document().its('readyState').should('eq', 'complete');
checkDeveloperPerspective(tries - 1);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's probably better just to wait for the rollout using CLI commands after the oc patch

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I will find the rollout command and update the code

frontend/packages/helm-plugin/integration-tests/support/commands/hooks.ts
Comment on lines +22 to +29
cy.exec(
`oc patch console.operator.openshift.io/cluster --type='merge' -p '{"spec":{"customization":{"perspectives":[{"id":"dev","visibility":{"state":"Enabled"}}]}}}'`,
{ failOnNonZeroExit: false },
);
cy.reload(true);
cy.document().its('readyState').should('eq', 'complete');
guidedTour.close();
checkDeveloperPerspective();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's avoid duplicate code if we can (here and below)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes these will be revamped based on your point here

frontend/packages/dev-console/integration-tests/support/commands/hooks.ts
@@ -19,7 +20,14 @@ before(() => {
const bridgePasswordPassword: string = Cypress.env('BRIDGE_HTPASSWD_PASSWORD') || 'test';
cy.login(bridgePasswordIDP, bridgePasswordUsername, bridgePasswordPassword);
cy.document().its('readyState').should('eq', 'complete');
cy.exec(
`oc patch console.operator.openshift.io/cluster --type='merge' -p '{"spec":{"customization":{"perspectives":[{"id":"dev","visibility":{"state":"Enabled"}}]}}}'`,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this only a stop-gap until we are able to update the tests?

We should be running most tests with default configuration if possible. I'd only expect a handful of tests to check the dev perspective works when enabled and the other tests be updated to use the admin perspective nav items to get to the same pages.

Copy link
Contributor Author

@sanketpathak sanketpathak Jan 21, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I was thinking of this pr as a stop-gap to unblock the pr openshift/console-operator#954 but as admin tests are also being updated I will update the tests to point to the admin side of things wherever it can be used

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spadgett spadgett spadgett requested changes

@ppitonak ppitonak Awaiting requested review from ppitonak

@The-Anton The-Anton Awaiting requested review from The-Anton

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/dev-console Related to dev-console component/helm Related to helm-plugin component/knative Related to knative-plugin component/pipelines Related to pipelines-plugin component/topology Related to topology jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sanketpathak @openshift-ci-robot @spadgett