Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFE-5765: Collect etcd object count #435

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

oarribas
Copy link
Contributor

Collects the etcd object count in the etcd_info directory as json file.

Copy link
Contributor

@RickJWagner RickJWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@oarribas
Copy link
Contributor Author

oarribas commented Aug 7, 2024

@davemulford , any thoughts on this?

@sferich888
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 18, 2024
Copy link
Contributor

openshift-ci bot commented Sep 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: oarribas, sferich888

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 18, 2024
@oarribas
Copy link
Contributor Author

oarribas commented Sep 19, 2024

Not sure why the jira/valid-reference label is missing, as this is linked to RFE-5765. Maybe RFEs are not valid as jira links?

@oarribas
Copy link
Contributor Author

@sferich888 , @RickJWagner , can you check the missing jira/valid-reference label?

@RickJWagner
Copy link
Contributor

Hi @oarribas
Thank you for this PR. About the valid-reference label, could you please re-name this Issue Tracker so the RFE isn't contained in square brackets?
I've been looking over other PRs, I didn't find any others that were referencing JIRAs in square brackets. (There were some others that used the brackets, but these were used for release numbers.)
If that doesn't work, we can ask Ben Parees, I think he's done a lot of the work in https://raw.githubusercontent.com/openshift-eng/jira-lifecycle-plugin/refs/heads/main/cmd/jira-lifecycle-plugin/server.go.

Please give it a shot, see if it works.

@oarribas oarribas changed the title [RFE-5765] Collect etcd object count RFE-5765: Collect etcd object count Oct 8, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 8, 2024

@oarribas: This pull request references RFE-5765 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the feature request to target the "4.18.0" version, but no target version was set.

In response to this:

Collects the etcd object count in the etcd_info directory as json file.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 8, 2024
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 175ca71 and 2 for PR HEAD 265f6d9 in total

Copy link
Contributor

openshift-ci bot commented Oct 8, 2024

@oarribas: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit a3ddf7f into openshift:master Oct 8, 2024
3 checks passed
@oarribas
Copy link
Contributor Author

oarribas commented Oct 8, 2024

/cherry-pick release-4.17

@openshift-cherrypick-robot

@oarribas: new pull request created: #453

In response to this:

/cherry-pick release-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@oarribas
Copy link
Contributor Author

oarribas commented Oct 8, 2024

/cherry-pick release-4.16

@openshift-cherrypick-robot

@oarribas: new pull request created: #454

In response to this:

/cherry-pick release-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@oarribas
Copy link
Contributor Author

oarribas commented Oct 8, 2024

/cherry-pick release-4.15

@openshift-cherrypick-robot

@oarribas: new pull request created: #456

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@oarribas
Copy link
Contributor Author

oarribas commented Oct 8, 2024

/cherry-pick release-4.14

@openshift-cherrypick-robot

@oarribas: new pull request created: #457

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-must-gather
This PR has been included in build ose-must-gather-container-v4.18.0-202410081810.p0.ga3ddf7f.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants