[release-4.17] OCPBUGS-42964: Collect etcd object count

[openshift-cherrypick-robot]

This is an automated cherry-pick of #435

/assign oarribas

[openshift-ci-robot]

@openshift-cherrypick-robot: Ignoring requests to cherry-pick non-bug issues: RFE-5765

In response to this:

This is an automated cherry-pick of #435

/assign oarribas

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[oarribas]

/retitle [release-4.17] OCPBUGS-42964: Collect etcd object count

[openshift-ci-robot]

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-42964, which is invalid:

• release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
• expected dependent Jira Issue OCPBUGS-42963 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is New instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #435

/assign oarribas

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[oarribas]

/jira refresh

[openshift-ci-robot]

@oarribas: This pull request references Jira Issue OCPBUGS-42964, which is invalid:

• release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[oarribas]

/jira refresh

[openshift-ci-robot]

@oarribas: This pull request references Jira Issue OCPBUGS-42964, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.17.z) matches configured target version for branch (4.17.z)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
• release note type set to "Release Note Not Required"
• dependent bug Jira Issue OCPBUGS-42963 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
• dependent Jira Issue OCPBUGS-42963 targets the "4.18.0" version, which is one of the valid target versions: 4.18.0
• bug has dependents

Requesting review from QA contact:
/cc @zhouying7780

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[zhouying7780]

/label cherry-pick-approved

[zhouying7780]

/label qe-approved

[openshift-ci-robot]

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-42964, which is valid.

7 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.17.z) matches configured target version for branch (4.17.z)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
• release note type set to "Release Note Not Required"
• dependent bug Jira Issue OCPBUGS-42963 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
• dependent Jira Issue OCPBUGS-42963 targets the "4.18.0" version, which is one of the valid target versions: 4.18.0
• bug has dependents

Requesting review from QA contact:
/cc @zhouying7780

In response to this:

This is an automated cherry-pick of #435

/assign oarribas

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[oarribas]

@RickJWagner , I can see you added the lgtm label to the 4.16 PR (#454 (comment)). Can it be added also to this one?

[RickJWagner]

/lgtm

[oarribas]

@RickJWagner , @zhouying7780 , this one (and the rest of cherry-picks) are pending on the backport-risk-assessed label. Who should provide it?

[davemulford]

@sferich888, this looks good to me. Any reason this can't be cherry-picked?

[sferich888]

@davemulford we don't typically backport new features; as that breaks/changes the API/ABI behavior of things.
That said as this is a diagnostics tool (we are a bit more lenient)

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, RickJWagner, sferich888

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• collection-scripts/OWNERS [RickJWagner,sferich888]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ingvagabund]

/label backport-risk-assessed

[ingvagabund]

@oarribas @davemulford how much important this addition is for older OCP versions? It's usually acceptable to backport one version back. Though, for older versions, additional justification would be useful. In the worst case 4.16/4.15 can run 4.17 must-gather image through --images option.

[openshift-ci]

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci-robot]

@openshift-cherrypick-robot: Jira Issue OCPBUGS-42964: All pull requests linked via external trackers have merged:

• openshift/must-gather#453

Jira Issue OCPBUGS-42964 has been moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #435

/assign oarribas

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[oarribas]

@oarribas @davemulford how much important this addition is for older OCP versions? It's usually acceptable to backport one version back. Though, for older versions, additional justification would be useful. In the worst case 4.16/4.15 can run 4.17 must-gather image through --images option.

@ingvagabund , having this data by default in must-gathers is really useful for support cases. As some customers provide must-gather in advance (without the --images option), it will be really helpful to have this backported to all supported releases. As commented by @sferich888:

[...] this is a diagnostics tool (we are a bit more lenient)"

And this PR is using same commands already used in the gather_etcd script (ocp4etcdctl command) for collect additional data.

[openshift-bot]

[ART PR BUILD NOTIFIER]

Distgit: ose-must-gather
This PR has been included in build ose-must-gather-container-v4.17.0-202411081836.p0.g1bce9ff.assembly.stream.el9.
All builds following this will include this PR.