Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds os_cloud_name variable for development_environment role #397

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

marios
Copy link
Contributor

@marios marios commented Apr 4, 2024

As part of [1] this adds a new os_cloud_name var for the development_environment role to be used with the prelaunch vm test instance creation. This retains current behaviour OS_CLOUD=standalone. Needed by [2].

https://issues.redhat.com/browse/OSPRH-5754

[1] https://issues.redhat.com/browse/OSPRH-3038
[2] https://review.rdoproject.org/r/c/rdo-jobs/+/52452

rdoproject pushed a commit to rdo-infra/rdo-jobs that referenced this pull request Apr 4, 2024
Wires up the test-minimal target from the data plane adoption tests repo
for the new tripleo multinode job. The overcloud/tripleo deployment was
added in the parent patch [1] and its depenencies. This is part of [2].

https://issues.redhat.com/browse/OSPRH-5754

Depends-On: openstack-k8s-operators/data-plane-adoption#397

[1] https://review.rdoproject.org/r/c/rdo-jobs/+/51916
[2] https://issues.redhat.com/browse/OSPRH-3038

Change-Id: I104399d783a46cd58b245a0aab0aa2e9ab6ffa0e
rdoproject pushed a commit to rdo-infra/rdo-jobs that referenced this pull request Apr 4, 2024
Wires up the test-minimal target from the data plane adoption tests repo
for the new tripleo multinode job. The overcloud/tripleo deployment was
added in the parent patch [1] and its depenencies. This is part of [2].

https://issues.redhat.com/browse/OSPRH-5754

Depends-On: openstack-k8s-operators/data-plane-adoption#397

[1] https://review.rdoproject.org/r/c/rdo-jobs/+/51916
[2] https://issues.redhat.com/browse/OSPRH-3038

Change-Id: I104399d783a46cd58b245a0aab0aa2e9ab6ffa0e
rdoproject pushed a commit to rdo-infra/rdo-jobs that referenced this pull request Apr 5, 2024
Wires up the test-minimal target from the data plane adoption tests repo
for the new tripleo multinode job. The overcloud/tripleo deployment was
added in the parent patch [1] and its depenencies. This is part of [2].

https://issues.redhat.com/browse/OSPRH-5754

Depends-On: openstack-k8s-operators/data-plane-adoption#397

[1] https://review.rdoproject.org/r/c/rdo-jobs/+/51916
[2] https://issues.redhat.com/browse/OSPRH-3038

Change-Id: I104399d783a46cd58b245a0aab0aa2e9ab6ffa0e
rdoproject pushed a commit to rdo-infra/rdo-jobs that referenced this pull request Apr 5, 2024
Wires up the test-minimal target from the data plane adoption tests repo
for the new tripleo multinode job. The overcloud/tripleo deployment was
added in the parent patch [1] and its depenencies. This is part of [2].

https://issues.redhat.com/browse/OSPRH-5754

Depends-On: openstack-k8s-operators/data-plane-adoption#397

[1] https://review.rdoproject.org/r/c/rdo-jobs/+/51916
[2] https://issues.redhat.com/browse/OSPRH-3038

Change-Id: I104399d783a46cd58b245a0aab0aa2e9ab6ffa0e
@marios marios marked this pull request as draft April 9, 2024 10:06
rdoproject pushed a commit to rdo-infra/rdo-jobs that referenced this pull request Apr 9, 2024
Wires up the test-minimal target from the data plane adoption tests repo
for the new tripleo multinode job. The overcloud/tripleo deployment was
added in the parent patch [1] and its depenencies. This is part of [2].

https://issues.redhat.com/browse/OSPRH-5754

Depends-On: openstack-k8s-operators/data-plane-adoption#397

[1] https://review.rdoproject.org/r/c/rdo-jobs/+/51916
[2] https://issues.redhat.com/browse/OSPRH-3038

Change-Id: I104399d783a46cd58b245a0aab0aa2e9ab6ffa0e
rdoproject pushed a commit to rdo-infra/rdo-jobs that referenced this pull request Apr 10, 2024
Wires up the test-minimal target from the data plane adoption tests repo
for the new tripleo multinode job. The overcloud/tripleo deployment was
added in the parent patch [1] and its depenencies. This is part of [2].

https://issues.redhat.com/browse/OSPRH-5754

Depends-On: openstack-k8s-operators/data-plane-adoption#397

[1] https://review.rdoproject.org/r/c/rdo-jobs/+/51916
[2] https://issues.redhat.com/browse/OSPRH-3038

Change-Id: I104399d783a46cd58b245a0aab0aa2e9ab6ffa0e
rdoproject pushed a commit to rdo-infra/rdo-jobs that referenced this pull request Apr 11, 2024
Wires up the test-minimal target from the data plane adoption tests repo
for the new tripleo multinode job. The overcloud/tripleo deployment was
added in the parent patch [1] and its depenencies. This is part of [2].

https://issues.redhat.com/browse/OSPRH-5754

Depends-On: openstack-k8s-operators/data-plane-adoption#397

[1] https://review.rdoproject.org/r/c/rdo-jobs/+/51916
[2] https://issues.redhat.com/browse/OSPRH-3038

Change-Id: I104399d783a46cd58b245a0aab0aa2e9ab6ffa0e
rdoproject pushed a commit to rdo-infra/rdo-jobs that referenced this pull request Apr 12, 2024
Wires up the test-minimal target from the data plane adoption tests repo
for the new tripleo multinode job. The overcloud/tripleo deployment was
added in the parent patch [1] and its depenencies. This is part of [2].

https://issues.redhat.com/browse/OSPRH-5754

Depends-On: openstack-k8s-operators/data-plane-adoption#397

[1] https://review.rdoproject.org/r/c/rdo-jobs/+/51916
[2] https://issues.redhat.com/browse/OSPRH-3038

Change-Id: I104399d783a46cd58b245a0aab0aa2e9ab6ffa0e
rdoproject pushed a commit to rdo-infra/rdo-jobs that referenced this pull request Apr 12, 2024
Wires up the test-minimal target from the data plane adoption tests repo
for the new tripleo multinode job. The overcloud/tripleo deployment was
added in the parent patch [1] and its depenencies. This is part of [2].

https://issues.redhat.com/browse/OSPRH-5754

Depends-On: openstack-k8s-operators/data-plane-adoption#397

[1] https://review.rdoproject.org/r/c/rdo-jobs/+/51916
[2] https://issues.redhat.com/browse/OSPRH-3038

Change-Id: I104399d783a46cd58b245a0aab0aa2e9ab6ffa0e
@@ -6,5 +6,5 @@
EDPM_PRIVATEKEY_PATH: "{{ edpm_privatekey_path }}"
ansible.builtin.shell:
cmd: |
alias openstack="ssh -i {{ edpm_privatekey_path }} root@{{ edpm_node_ip }} OS_CLOUD=standalone openstack"
alias openstack="ssh -i {{ edpm_privatekey_path }} root@{{ edpm_node_ip }} OS_CLOUD={{ os_cloud_name }} openstack"
Copy link
Contributor Author

@marios marios Apr 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a new var to point to undercloud here... keep edpm_node_ip for the compute node.

EDIT: (as discussed in a call today with Gibi and Joan)

rdoproject pushed a commit to rdo-infra/rdo-jobs that referenced this pull request Apr 15, 2024
Wires up the test-minimal target from the data plane adoption tests repo
for the new tripleo multinode job. The overcloud/tripleo deployment was
added in the parent patch [1] and its depenencies. This is part of [2].

https://issues.redhat.com/browse/OSPRH-5754

Depends-On: openstack-k8s-operators/data-plane-adoption#397

[1] https://review.rdoproject.org/r/c/rdo-jobs/+/51916
[2] https://issues.redhat.com/browse/OSPRH-3038

Change-Id: I104399d783a46cd58b245a0aab0aa2e9ab6ffa0e
rdoproject pushed a commit to rdo-infra/rdo-jobs that referenced this pull request Apr 16, 2024
Wires up the test-minimal target from the data plane adoption tests repo
for the new tripleo multinode job. The overcloud/tripleo deployment was
added in the parent patch [1] and its depenencies. This is part of [2].

https://issues.redhat.com/browse/OSPRH-5754

Depends-On: openstack-k8s-operators/data-plane-adoption#397

[1] https://review.rdoproject.org/r/c/rdo-jobs/+/51916
[2] https://issues.redhat.com/browse/OSPRH-3038

Change-Id: I104399d783a46cd58b245a0aab0aa2e9ab6ffa0e
rdoproject pushed a commit to rdo-infra/rdo-jobs that referenced this pull request Apr 16, 2024
Wires up the test-minimal target from the data plane adoption tests repo
for the new tripleo multinode job. The overcloud/tripleo deployment was
added in the parent patch [1] and its depenencies. This is part of [2].

https://issues.redhat.com/browse/OSPRH-5754

Depends-On: openstack-k8s-operators/data-plane-adoption#397

[1] https://review.rdoproject.org/r/c/rdo-jobs/+/51916
[2] https://issues.redhat.com/browse/OSPRH-3038

Change-Id: I104399d783a46cd58b245a0aab0aa2e9ab6ffa0e
rdoproject pushed a commit to rdo-infra/rdo-jobs that referenced this pull request Apr 18, 2024
Wires up the test-minimal target from the data plane adoption tests repo
for the new tripleo multinode job. The overcloud/tripleo deployment was
added in the parent patch [1] and its depenencies. This is part of [2].

https://issues.redhat.com/browse/OSPRH-5754

Depends-On: openstack-k8s-operators/data-plane-adoption#397

[1] https://review.rdoproject.org/r/c/rdo-jobs/+/51916
[2] https://issues.redhat.com/browse/OSPRH-3038

Change-Id: I104399d783a46cd58b245a0aab0aa2e9ab6ffa0e
rdoproject pushed a commit to rdo-infra/rdo-jobs that referenced this pull request Apr 18, 2024
Patch Set 17: Verified-1

This change depends on a change that failed to merge.

Change openstack-k8s-operators/data-plane-adoption#397 is needed.

Patch-set: 17
Reviewer: Gerrit User 499 <499@270e2033-b340-4cff-9539-693957ebf0e7>
Label: Verified=-1, b28d4b37e55c08a30cf5a8eb251577aafdd6a4f0
Attention: {"person_ident":"Gerrit User 192 \u003c192@270e2033-b340-4cff-9539-693957ebf0e7\u003e","operation":"ADD","reason":"A robot voted negatively on a label"}
rdoproject pushed a commit to rdo-infra/rdo-jobs that referenced this pull request Apr 18, 2024
Wires up the test-minimal target from the data plane adoption tests repo
for the new tripleo multinode job. The overcloud/tripleo deployment was
added in the parent patch [1] and its depenencies. This is part of [2].

https://issues.redhat.com/browse/OSPRH-5754

Depends-On: openstack-k8s-operators/data-plane-adoption#397

[1] https://review.rdoproject.org/r/c/rdo-jobs/+/51916
[2] https://issues.redhat.com/browse/OSPRH-3038

Change-Id: I104399d783a46cd58b245a0aab0aa2e9ab6ffa0e
rdoproject pushed a commit to rdo-infra/rdo-jobs that referenced this pull request Apr 18, 2024
Patch Set 18: Verified-1

This change depends on a change that failed to merge.

Change openstack-k8s-operators/data-plane-adoption#397 is needed.

Patch-set: 18
Reviewer: Gerrit User 499 <499@270e2033-b340-4cff-9539-693957ebf0e7>
Label: Verified=-1, fd134704ea5710c0264857ad2f346c9011fa8e7b
Attention: {"person_ident":"Gerrit User 192 \u003c192@270e2033-b340-4cff-9539-693957ebf0e7\u003e","operation":"ADD","reason":"A robot voted negatively on a label"}
rdoproject pushed a commit to rdo-infra/rdo-jobs that referenced this pull request Apr 19, 2024
Wires up the test-minimal target from the data plane adoption tests repo
for the new tripleo multinode job. The overcloud/tripleo deployment was
added in the parent patch [1] and its depenencies. This is part of [2].

https://issues.redhat.com/browse/OSPRH-5754

Depends-On: openstack-k8s-operators/data-plane-adoption#397

[1] https://review.rdoproject.org/r/c/rdo-jobs/+/51916
[2] https://issues.redhat.com/browse/OSPRH-3038

Change-Id: I104399d783a46cd58b245a0aab0aa2e9ab6ffa0e
rdoproject pushed a commit to rdo-infra/rdo-jobs that referenced this pull request Apr 22, 2024
Wires up the test-minimal target from the data plane adoption tests repo
for the new tripleo multinode job. The overcloud/tripleo deployment was
added in the parent patch [1] and its depenencies. This is part of [2].

https://issues.redhat.com/browse/OSPRH-5754

Depends-On: openstack-k8s-operators/data-plane-adoption#397

[1] https://review.rdoproject.org/r/c/rdo-jobs/+/51916
[2] https://issues.redhat.com/browse/OSPRH-3038

Change-Id: I104399d783a46cd58b245a0aab0aa2e9ab6ffa0e
rdoproject pushed a commit to rdo-infra/rdo-jobs that referenced this pull request Apr 24, 2024
Wires up the test-minimal target from the data plane adoption tests repo
for the new tripleo multinode job. The overcloud/tripleo deployment was
added in the parent patch [1] and its depenencies. This is part of [2].

https://issues.redhat.com/browse/OSPRH-5754

Depends-On: openstack-k8s-operators/data-plane-adoption#397

[1] https://review.rdoproject.org/r/c/rdo-jobs/+/51916
[2] https://issues.redhat.com/browse/OSPRH-3038

Change-Id: I104399d783a46cd58b245a0aab0aa2e9ab6ffa0e
@marios marios force-pushed the OSPRH-5754 branch 2 times, most recently from ee241e5 to 36a5128 Compare April 24, 2024 10:47
As part of [1] this adds a new os_cloud_name var for the
development_environment role to be used with the prelaunch vm test
instance creation. This retains current behaviour OS_CLOUD=standalone.
Needed by [2].

https://issues.redhat.com/browse/OSPRH-5754

[1] https://issues.redhat.com/browse/OSPRH-3038
[2] https://review.rdoproject.org/r/c/rdo-jobs/+/52452
rdoproject pushed a commit to rdo-infra/rdo-jobs that referenced this pull request Apr 25, 2024
Wires up the test-minimal target from the data plane adoption tests repo
for the new tripleo multinode job. The overcloud/tripleo deployment was
added in the parent patch [1] and its depenencies. This is part of [2].

The periodic-data-plane-adoption-multinode-osp-17-to-extracted-crc-no-ceph is
wired up to run next to the existing job, but not yet in promotion criteria.

https://issues.redhat.com/browse/OSPRH-5754

Depends-On: openstack-k8s-operators/data-plane-adoption#397

[1] https://review.rdoproject.org/r/c/rdo-jobs/+/51916
[2] https://issues.redhat.com/browse/OSPRH-3038

Change-Id: I104399d783a46cd58b245a0aab0aa2e9ab6ffa0e
rdoproject pushed a commit to rdo-infra/rdo-jobs that referenced this pull request Apr 26, 2024
Wires up the test-minimal target from the data plane adoption tests repo
for the new tripleo multinode job. The overcloud/tripleo deployment was
added in the parent patch [1] and its depenencies. This is part of [2].

The periodic-data-plane-adoption-multinode-osp-17-to-extracted-crc-no-ceph is
wired up to run next to the existing job, but not yet in promotion criteria.

https://issues.redhat.com/browse/OSPRH-5754

Depends-On: openstack-k8s-operators/data-plane-adoption#397

[1] https://review.rdoproject.org/r/c/rdo-jobs/+/51916
[2] https://issues.redhat.com/browse/OSPRH-3038

Change-Id: I104399d783a46cd58b245a0aab0aa2e9ab6ffa0e
@marios marios marked this pull request as ready for review April 26, 2024 12:49
@marios
Copy link
Contributor Author

marios commented Apr 26, 2024

as discussed today we are going to merge this and the patch that depends-on it at https://review.rdoproject.org/r/c/rdo-jobs/+/52452 so we'll start running the non-ceph 3 control 1 compute job in the periodic line, even though it isn't green yet.

it makes life easier moving forward with the remaining tasks and multiple ongoing parallel efforts

@cescgina
Copy link
Contributor

Merging as it has twice the amount of approvals needed :)

@cescgina cescgina merged commit ea83e28 into openstack-k8s-operators:main Apr 26, 2024
2 checks passed
rdoproject pushed a commit to rdo-infra/rdo-jobs that referenced this pull request Apr 29, 2024
Wires up the test-minimal target from the data plane adoption tests repo
for the new tripleo multinode job. The overcloud/tripleo deployment was
added in the parent patch [1] and its depenencies. This is part of [2].

The periodic-data-plane-adoption-multinode-osp-17-to-extracted-crc-no-ceph is
wired up to run next to the existing job, but not yet in promotion criteria.

https://issues.redhat.com/browse/OSPRH-5754

Depends-On: openstack-k8s-operators/data-plane-adoption#397

[1] https://review.rdoproject.org/r/c/rdo-jobs/+/51916
[2] https://issues.redhat.com/browse/OSPRH-3038

Change-Id: I104399d783a46cd58b245a0aab0aa2e9ab6ffa0e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants