Add openstack_cleanup_all make target #970
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: weinimo The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
weinimo
force-pushed
the
add_os_cleanup_all_target
branch
from
5aaeffa to
efa4d71
Compare
Goal of this new make target is to clean up everything that may be necessary in order to re-run `make openstack` successfully if it failed before.
weinimo
force-pushed
the
add_os_cleanup_all_target
branch
from
efa4d71 to
7b517f3
Compare
There was a problem hiding this comment.
what is the goal for this target? because make openstack only installs the operators and its dependencies. it does not deploy the ctlplane. should it also cleanup the deployment, like make openstack_deploy_cleanup
Because of that the usual workflow is to run
make openstack_deploy_cleanup
<wait for the deployemts gone>
make openstack_cleanup
make crc_storage_cleanup
...
there you could add the nncp_cleanup at the end and the namespace_cleanup. if you do not wait for the ctlplane resources cleanup up before uninstall the operators, you will have remaining objects with a finalizer. as a result you won't be able to delete the namespace
if you uninstall the operators, the CRDs are still on the cluster. if you also want to remove those, you'd have to run openstack_crds_cleanup.
metallb resource are in the metallb-system namespace. metallb_config_cleanup would remove those, and if you also want to uninstall that operator metallb_cleanup.
similar to cert-manager certmanager_cleanup
| @@ -747,6 +747,10 @@ openstack_cleanup: operator_namespace## deletes the operator, but does not clean | |||
| oc delete catalogsource --all=true | |||
| test -d ${OPERATOR_BASE_DIR}/baremetal-operator && make crc_bmo_cleanup || true | |||
|
|
|||
| .PHONY: openstack_cleanup_all | |||
| openstack_cleanup_all: openstack_cleanup nncp_cleanup namespace_cleanup ## deletes the operator and its resources | |||
There was a problem hiding this comment.
this won't work. openstack_cleanup will uninstall the operators. if they are down, you can not cleanup the openstack namespace.
There was a problem hiding this comment.
So I just need to switch the order?
|
@weinimo: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Goal of this new make target is to clean up everything that may be necessary in order to re-run
make openstacksuccessfully if it failed before.