Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add openstack_cleanup_all make target #970

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −0
Open

Add openstack_cleanup_all make target #970

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -747,6 +747,10 @@ openstack_cleanup: operator_namespace## deletes the operator, but does not clean
oc delete catalogsource --all=true
test -d ${OPERATOR_BASE_DIR}/baremetal-operator && make crc_bmo_cleanup || true

.PHONY: openstack_cleanup_all
openstack_cleanup_all: openstack_cleanup nncp_cleanup namespace_cleanup ## deletes the operator and its resources
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this won't work. openstack_cleanup will uninstall the operators. if they are down, you can not cleanup the openstack namespace.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I just need to switch the order?

@echo "Completed full cleanup."

.PHONY: openstack_repo
openstack_repo: export REPO=${OPENSTACK_REPO}
openstack_repo: export BRANCH=${OPENSTACK_BRANCH}
Expand Down