fix: correctly reflect damage

[un000000]

Description

Behaviour

Actual

Damaging enemy with type they reflect heals you for ~42 million hp if you are using ek/rp weapons.

Expected

Damaging enemy with type they reflect damages you according to reflect map when using any damage source.

Fixes #1719

Type of change

• Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested

I equipped fire axe and bonked gazer spectre. This resulted me receiving about 450 damage from reflect, and spectre received 80 damage. Did same with royal star - this resulted in smaller values, correct nevertheless.

Test Configuration:

• Server Version: up to commit ce7e977
• Client: 13.21
• Operating System: Win 10

[un000000]

I fixed problem mentined by @Schiffers in 5ad00a8. Now reflected damage is based on damage after mitigation (actual dmg monster was hit for).

I changed pr name accordingly.

[Schiffers]

I fixed problem mentined by @Schiffers in 5ad00a8. Now reflected damage is based on damage after mitigation (actual dmg monster was hit for).

I changed pr name accordingly.

I've done some tests and works fine.

[Schiffers]

I've done another tests... now the reflect damage by agony damage don't work as before.

works with monster with alot of hp, but with rats the damage don't apply.

[un000000]

I've done another tests... now the reflect damage by agony damage don't work as before.

works with monster with a lot of hp, but with rats the damage don't apply.

This is because in the line below, there is a check that guarantees that the reflected damage isn't higher than attacker damage.

Earlier it used pre-mitigation damage. So when rat rolls say 2 damage, you can reflect damage lower or equal to 2 damage.

Now its calculated based on post-mitigation damage (actual health loss), so with crazy high level, and endgame armor, rat is always gonna hit you for 0 damage, thus no reflect damage will occur.

If it's not intended, then I would just remove "damage.secondary.value" from all three places where reflect is calculated.

canary/src/game/game.cpp

Line 6067 in 62995d6

damageReflected.primary.value = std::ceil(damage.secondary.value * secondaryReflectPercent / 100.) + std::max(-static_cast<int32_t>(std::ceil(attacker->getMaxHealth() * 0.01)), std::max(damage.secondary.value, -(static_cast<int32_t>(secondaryReflectFlat))));

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information