Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: kv: quests #2099

Merged
merged 8 commits into from
Mar 6, 2024
Merged

feat: kv: quests #2099

merged 8 commits into from
Mar 6, 2024

Conversation

majestyotbr
Copy link
Contributor

@majestyotbr majestyotbr commented Jan 11, 2024

Description

Function to register quests using KV.
Example of quest using KV and Position, Rapier Quest on Rookgaard.
Removed action id 2000, unique id 64120 and the rapier from the box on position {x = 32099, y = 32198, z = 9}.

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested

  • Go to the position {x = 32099, y = 32198, z = 9}, click in the box and receive the reward.

Test Configuration:

  • Server Version: Canary 3.1.2
  • Client: 13.21
  • Operating System: Windows

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@enzerah
Copy link
Contributor

enzerah commented Jan 12, 2024

alot easier to make quests rn.

awesome

@majestyotbr majestyotbr marked this pull request as draft January 12, 2024 11:32
@majestyotbr majestyotbr marked this pull request as ready for review January 12, 2024 17:28
@majestyotbr majestyotbr force-pushed the questKV branch 3 times, most recently from eb52034 to bcfacdb Compare January 14, 2024 03:25
@majestyotbr majestyotbr marked this pull request as draft January 14, 2024 10:40

This comment has been minimized.

@dudantas dudantas marked this pull request as ready for review February 23, 2024 20:49
@majestyotbr majestyotbr marked this pull request as draft February 24, 2024 12:49
@elsongabriel
Copy link
Contributor

elsongabriel commented Mar 6, 2024

tested ok!
image
image

normal player
image

@majestyotbr majestyotbr marked this pull request as ready for review March 6, 2024 21:56
@majestyotbr majestyotbr merged commit ac3f183 into main Mar 6, 2024
35 checks passed
@majestyotbr majestyotbr deleted the questKV branch March 6, 2024 22:06
@GuiValladao GuiValladao mentioned this pull request Jun 2, 2024
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants