Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revised some quests #2675

Merged
merged 10 commits into from
Jul 25, 2024
Merged

Conversation

GuiValladao
Copy link
Contributor

I started reviewing some quests listed here.

Because they are simple, I redid most of them in kv, so I will leave the list of changes that need to be made to the map. Most of the changes are removing aid and uid.

If anyone can link the changes to fix :map I would greatly appreciate it! (I'm not good with github).

Newbie Islands Quests:

  • Bear Room Quest
    Position:(32146, 32097, 11) - chest
    Remove aid 2000, remove uid 64116, remove contents.
    Position:(32144, 32096, 11) - chest
    Remove aid 2000, remove uid 64115, remove contents.
    Position:(32141, 32097, 11) - chest
    Remove aid 2000, remove uid 64114, remove contents.
    Position:(32150, 32112, 12) - chest
    Remove aid 2000, remove uid 64113, remove contents.
    Position:(32145, 32100, 11) - door
    Remove aid 4601.
    Position:(32148, 32105, 11) - lever
    Remove uid 1056.
    Position:(32149, 32110, 11) - trapdoor
    Delete and replate to dirt floor id 355.
    (Fix the pickaxe path: data-otservbr-global/startup/tables/tile_pick.lua)

  • Captain Iglues Treasure Quest
    Position:(32039, 32121, 13) - chest
    Remove aid 2000 remove uid 64118 remove contents.

  • Child of Destiny Quest
    It doesn't exist anymore, so I assumed it didn't need to be revised.

  • Combat Knife Quest
    Position:(32102, 32235, 8)
    Remove aid 2000 remove uid 64119.

  • Dawnport Quest
    -- Mission 'Lost Amulet' --
    Fix worms id
    Fix questlog misspell.
    -- The Stolen Log Book --
    Fix questlog misspell.
    -- The Rare Herb --
    Fix questlog misspell.
    -- Tasks --
    Fix all 3 tasks count on quest log.

  • Doublet Quest
    Position:(32084, 32181, 8) - floor
    Remove aid 5639.

  • Dragon Corpse Quest
    Position:(32179, 32224, 9) - dragon corpse
    Remove aid 2000, remove uid 64122, remove contents.

  • Goblin Temple Quest
    Position:(31973, 32209, 12) - chest
    Remove aid 2000, remove uid 64123, remove contents.
    Position:(31977, 32209, 12) - chest
    Remove aid 2000, remove uid 64124, remove contents.

  • Katana Quest
    Position:(32169, 32157, 8) - random place
    Remove random uid 5636.
    Position:(32176, 32132, 9) - human corpse
    Remove aid 2000, remove uid 64110, remove contents.
    Position:(32179, 32149, 10) - door
    Remove aid 4693.
    Position:(32182, 32145, 11) - level
    Remove uid 1054.
    Position:(32177, 32148, 11) - door
    Remove uid 1055.
    Position:(32175, 32145, 11) - human corpse
    Remove aid 2000, remove uid, 64112 remove contents.
    Position:(32174, 32149, 11) - human corpse
    Remove aid 2000, remove uid 64111, remove contents.

  • Minotaur Hell Quest
    Position:(32130, 32066, 12) - box
    Remove aid 2000, remove uid 64127, remove contents.
    Position:(32127, 32065, 12) - box
    Remove aid 2000, remove uid 64126, remove contents.
    Position:(32124, 32064, 12) - box
    Remove aid 2000, remove uid 64125, remove contents.

  • Rapier Quest
    Already done. feat: kv: quests #2099

  • Sanctuary of the Lizard God Quest
    Tested all OK.

  • The Rookie Guard Quest
    Fix max level cap - I didn't review the rest yet.

  • Tutorial
    It doesn't exist anymore, so I assumed it didn't need to be revised.

Newbie Islands Exchange Quests:

I will try to continue reviewing the quests according to my free time.
Any suggestions, please let me now!

@elsongabriel
Copy link
Contributor

@phacUFPE can you help, with map modifications? tks.

@elsongabriel elsongabriel requested a review from phacUFPE June 4, 2024 12:28
@phacUFPE
Copy link
Contributor

phacUFPE commented Jun 4, 2024

@phacUFPE can you help, with map modifications? tks.

Of course, I'll do the modifications when I'll be available.

@phacUFPE
Copy link
Contributor

phacUFPE commented Jun 5, 2024

@elsongabriel map modifications requested in this PR done!

@GuiValladao GuiValladao marked this pull request as draft June 5, 2024 13:53
@GuiValladao
Copy link
Contributor Author

I changed the system in "quest_reward_common.lua" so that "chest.lua" would accept quests in kv without the need for an additional script.

Unfortunately I'm short on free time so I'm going to leave these changes out of draft and continue the changes in the future.
I did not change quest storage with questlog or quests that will possibly use storage for websites, etc.

Part 2

  • The Rookie Guard Quest
    Fix max level cap
    Fix rat task count quest log (mission 3)
    Position: (32051, 32110, 7) - Replace hole id 12728 to hole id 385
    Position: (32018, 32098, 11) - same
    Position: (32138, 32132, 7) - same
    Position: (32059, 32135, 9) - same
    Position: (32106, 32130, 10) - same

  • Tutorial
    Don't exist anymore.
    I took a look and the quest releases those pop-ups like in dwarport but wrong. I don't know how it works so I didn't delve deeper.
    Recommendation: Remove the Aids from the RME and forget about it.

  • Child of Destiny Quest
    Don't exist anymore.
    I also took a look. There is no script or NPC talk for this quest in the current Canary.
    The NPC the Oracle also does not show any option to take the player to the Isle of Destiny.
    Same recommendation: Remove the Aids from the RME and forget about it.

Newbie Islands Addon Quests:

Mainland Quests:

  • Battle Axe Quest
    Position: (32302, 32257, 8) - Remove aid 101 - floor
    Position: (32305, 32254, 9) - Remove aid 2001 - skeleton corpse

  • Blood Herb Quest
    Position: (32769, 31968, 7) - Remove aid 2001 remove uid 50032 - dead tree

  • Circle Room Quest
    Position:(32495, 31992, 14) - Remove aid 2000, remove uid 9149, remove contents - box
    Position:(32497, 31992, 14) - Remove aid 2000, remove uid 9148, remove contents - box

  • Crusader Helmet Quest
    Position:(32427, 31943, 14) - Remove aid 2000, remove uid 9191, remove contents - demon skeleton corpse

  • Crystal Wand Quest
    Done at Demona Quest

  • Dead Archer Quest
    Done at Thais Quest

  • Deeper Fibula Quest
    Position:(32171, 32439, 7) - Remove aid 102 - draw well
    Position:(32172, 32439, 7) - Remove aid 102 - draw well
    Position:(32277, 32420, 10) - Remove aid 3980 - door
    Position:(32245, 32492, 10) - Remove aid 2000, remove uid 9124, remove contents - dragon corpse
    Position:(32233, 32491, 10) - Remove aid 2000, remove uid 9123, remove contents - human corpse
    Position:(32256, 32500, 10) - Remove aid 2000, remove uid 9125, remove contents - human corpse
    Position:(32239, 32478, 10) - Remove aid 2000, remove uid 9126, remove contents - skeleton corpse
    Position:(32239, 325471, 10) - Remove aid 2000, remove uid 9122, remove contents - skeleton corpse

  • Demona Quest
    Position:(32498, 31721, 15) - Remove aid 2000, remove uid 9131, remove contents - corpse
    Position:(32500, 31721, 15) - Remove aid 2000, remove uid 9132, remove contents - corpse
    Position:(32503, 31724, 15) - Remove aid 2000, remove uid 9133, remove contents - corpse
    Position:(32483, 31722, 15) - Remove aid 1060 door
    Position:(32479, 31611, 15) - Remove aid 2000, remove uid 9144, remove contents - chest
    Position:(32481, 31611, 15) - Remove aid 2000, remove uid 9143, remove contents - chest
    Position:(32504, 31596, 14) - Remove aid 2000, remove uid 64131, remove contents - chest
    Position:(32515, 31596, 14) - Remove aid 2000, remove uid 64132, remove contents - chest
    Position:(32424, 31591, 15) - Remove aid 2000, remove uid 9188, remove contents - bookcase
    Position:(32427, 31591, 15) - Remove aid 2000, remove uid 9201, remove contents - bookcase
    Position:(32421, 31594, 15) - Remove aid 2000, remove uid 9200, remove contents - bookcase

  • Demona Ring Quest
    Done at Demona Quest

  • Devil Helmet Quest
    Done at Mintwallin Quest

  • • [Elvenbane Quest]https://tibia.fandom.com/wiki/Elvenbane_Quest/Spoiler)
    Position:(32588, 31644, 3) - Remove aid 2000, remove uid 50049, remove contents - drawers
    Position:(32588, 31645, 3) - Remove aid 2000, remove uid 50050, remove contents - drawers
    Position:(32590, 31647, 3) - Remove aid 2000, remove uid 50051, remove contents - chest
    Position:(32591, 31647, 3) - Remove aid 2000, remove uid 50052, remove contents - chest

  • Fanfare Quest
    Position:(32376, 31802, 7) - Remove aid 2000, remove uid 50031, remove contents - box
    Position:(32400, 31788, 8) - Remove aid 3520 - door
    Position:(32400, 31789, 8) - Remove aid 3520 - door
    Position:(32398, 31804, 8) - Remove aid 3520 - door
    Position:(32390, 31769, 9) - Remove aid 2000, remove uid 2282, remove contents - chest

  • Geomancer Quest
    Done at Thais Quest.

  • Ghoul Room Quest
    Done at Mintwallin Quest.

  • Griffin Shield Quest
    Done at Demona Quest.

  • Heaven Blossom Quest
    Position:(33104, 32154, 8) - Remove aid 2000, remove uid 50067, remove contents - barrel

  • Iron Helmet Quest
    Position:(32769, 32225, 7) - Remove aid 2000, remove uid 9180, remove contents - human corpse

  • Iron Ore Quest
    Position:(32532, 31873, 8) - Remove aid 2000, remove uid 50075, remove contents - chest

  • Isle of the Mists Quest
    Position:(32852, 32332, 7) - Remove aid 2000, remove uid 50077, remove contents - box

  • Kingdom of Kormarak Quest
    Done at Thais Quest.

  • Life Ring Quest
    Done at Thais Quest.

  • Longsword Quest
    Position:(32649, 31969, 9) - Remove aid 2000, remove uid 9290, remove contents - chest
    Position:(32650, 31969, 9) - Remove aid 2000, remove uid 9291, remove contents - chest
    Position:(32651, 31969, 9) - Remove aid 2000, remove uid 9292, remove contents - chest

  • Minotaur Leather Quest
    Position:(32302, 32415, 7) - Remove aid 2000, remove uid 9285, remove contents - box

  • Mintwallin Cyclops Quest
    Done at Mintwallin Quest.

  • Mintwallin Quest
    Position:(32507, 32176, 13) - Remove aid 102 - draw well
    Position:(32508, 32176, 13) - Remove aid 102 - draw well
    Position:(32509, 32181, 13) - Remove aid 2000, remove uid 9225, remove contents - skeleton corpse
    Position:(32500, 32175, 14) - Remove aid 2000, remove uid 9128, remove contents - chest
    Position:(32500, 32177, 14) - Remove aid 2000, remove uid 9129, remove contents - chest
    Position:(32552, 32200, 11) - Remove aid 2000, remove uid 64136, remove contents - human corpse
    Position:(32544, 32179, 14) - Remove aid 1040 - door
    Position:(32576, 32216, 15) - Remove aid 2000, remove uid 9129, remove contents - human corpse
    Position:(32600, 32105, 14) - Remove aid 20594 - lever
    Position:(32592, 32102, 14) - Remove aid 3667 - door
    Position:(32589, 32100, 14) - Remove aid 2001, remove uid 65202 - hole
    Position:(32591, 32097, 14) - Remove aid 2001, remove uid 65211 - chest
    Position:(32468, 32119, 14) - Remove uid 65203 - tile
    Position:(32479, 32174, 15) - Remove aid 1030 - door
    Position:(32459, 32144, 15) - Remove aid 2001, remove uid 65206 - chest
    Position:(32465, 32148, 15) - Remove aid 2001, remove uid 65205 - chest
    Position:(32466, 32148, 15) - Remove aid 2001, remove uid 65204 - chest
    Position:(32462, 32153, 14) - Replate door id 1632 to door id 1631
    Position:(32462, 32151, 15) - Replate door id 1629 to door id 1628
    Position:(32517, 32107, 14) - Remove aid 101 - floor
    Position:(32522, 32111, 15) - Remove aid 2000, remove uid 50063, remove contents - box

  • Naginata Quest
    Position:(32356, 32074, 10) - Remove aid 50058 - stone
    Position:(32353, 32073, 11) - Remove aid 1040 - door
    Position:(32346, 32063, 12) - Remove aid 2000, remove uid 9163, remove contents - chest

  • Noble Armor Quest
    Done at Thais Quest.

  • Orc Shaman Quest
    Position:(33089, 32030, 9) - Remove aid 2000, remove uid 50048, remove contents - box

  • Ornamented Shield Quest
    Position:(32774, 32289, 10) - Remove aid 101- floor

  • Power Bolts Quest
    Position:(32814, 32281, 8) - Remove aid 2000, remove uid 9179, remove contents - human corpse
    Position:(32816, 32279, 8) - Remove aid 2000, remove uid 9178, remove contents - human corpse

  • Power Ring Quest
    Position:(32599, 31776, 9) - Remove aid 2000, remove uid 50046, remove contents - box
    Position:(32601, 31776, 9) - Remove aid 2000, remove uid 50047, remove contents - box

  • Purple Tome Quest
    Done at Demona Quest

  • Scale Armor Quest
    Position:(32353, 32131, 8) - Remove aid 102 - draw well
    Position:(32354, 32131, 8) - Remove aid 102 - draw well
    Position:(32357, 32130, 9) - Remove aid 2000, remove uid 50076, remove contents - chest

  • Silver Amulet Quest
    Position:(32506, 32269, 9) - Remove aid 2001, remove uid 65209, remove contents - box

  • Silver Brooch Quest
    Position:(32775, 32012, 10) - Remove aid 101 - floor
    Position:(32775, 32006, 11) - Remove aid 2001, remove uid 9185 - wooden coffin

  • Six Rubies Quest
    Position:(32371, 32262, 12) - Remove aid 2001, remove uid 3002 - hole

  • Small Ruby Quest
    OK

  • Spike Sword Quest
    Position:(32595, 32068, 9) - Remove aid 101 - floor
    Position:(32580, 32103, 11) - Remove aid 101 - floor
    Position:(32568, 32085, 12) - Remove aid 2000, remove uid 9145, remove contents - demon skeleton corpse

  • Thais Quest
    Position:(32514, 32303, 10) - Remove aid 2000, remove uid 50045, remove contents - human corpse
    Position:(32414, 32252, 10) - Remove aid 50129 - lever
    Position:(32413, 32230, 10) - Remove aid 50129 - lever
    Position:(32437, 32239, 10) - Remove aid 101 - floor
    Position:(32443, 32238, 11) - Remove aid 2000, remove uid 2237, remove contents - box
    Position:(32451, 32048, 8) - Remove aid 2000, remove uid 9157, remove contents - chest
    Position:(32455, 32048, 8) - Remove aid 2000, remove uid 9156, remove contents - chest
    Position:(32448, 32042, 8) - Remove aid 1035 - door
    Position:(32450, 32044, 8) - Remove aid 3142 - door
    Position:(32456, 32008, 13) - Remove aid 2000, remove uid 50066, remove contents - box

  • Thais Lighthouse Quest
    Done at Thais Quest

  • The Desert Dungeon Quest
    Position:(32673, 32100, 8) - Remove aid 1020 - door
    Position:(32673, 32086, 8) - Remove uid 1912 - lever
    Position:(32668, 32069, 8) - Remove aid 2000, remove uid 9158, remove contents - chest
    Position:(32675, 32069, 8) - Remove aid 2000, remove uid 9159, remove contents - chest

  • The Outlaw Camp Quest
    Add Questlog
    Position:(32612, 32253, 7) - Remove aid 1045 - door
    Position:(32617, 32250, 7) - Remove aid 2001, remove uid 3311 - dead tree
    Position:(32609, 32244, 7) - Remove aid 2001, remove uid 3312 - dead tree
    Position:(32651, 32244, 7) - Remove aid 2001, remove uid 3313 - dead tree
    Position:(32614, 32175, 9) - Remove aid 3303 - door
    Position:(32614, 32173, 9) - Remove uid 3400 - lever
    Position:(32623, 32187, 9) - Remove aid 2000, remove uid 3314, remove contents - chest
    Position:(32619, 32248, 6) - Remove aid 5634 - floor
    Position:(32594, 32212, 9) - Remove uid 3401 - lever
    Position:(32602, 32207, 10) - Remove aid 1045 - door
    Position:(32619, 32241, 8) - Replace door id 12035 to door id 1631 with no aid 3301
    Position:(32619, 32240, 8) - Replace door id 12035 to door id 1631 with no aid 3302
    Position:(32614, 32230, 10) - Add rubble id 5868 to block the way
    Position:(32616, 32222, 10) - Remove uid 3402 - lever
    Position:(32620, 32199, 10) - Remove aid 3304 - door
    Position:(32620, 32198, 10) - Remove aid 2000, remove uid 9134, remove contents - chest

  • Throwing Star Quest
    Done at Mintwallin Quest.

  • Triangle Tower Quest
    Position:(32573, 32121, 7) - Remove uid 50023 - lever
    Position:(32565, 32119, 3) - Remove aid 2000, remove uid 9197, remove contents - chest

  • • [6.1]Emperor's Cookies Quest
    Done at chest.lua

  • • [6.1]Explorer Brooch Quest
    Switch to kv

  • • [6.1]Orc Fortress Quest
    Switch to kv

  • • [6.1]Panpipe Quest
    Switch to kv

  • • [6.2]Draconia Quest
    Position:(32794, 31572, 7) - Add aid 3001 at key inside skeleton corpse (NOTE: this key is dialy spawn, not a quest reward).
    Position:(32802, 31576, 7) - Add aid 3002 at key (NOTE: this key is dialy spawn, not a quest reward).
    Position:(32792, 31579, 7) - Remove aid 4250 - lever
    Position:(32790, 31593, 7) - Add aid 3003 at key (NOTE: this key is dialy spawn, not a quest reward).
    Position:(32807, 31576, 6) - Add aid 3004 at key (key is under the energy field)(NOTE: this key is dialy spawn, not a quest reward).
    Position:(32792, 31590, 6) - Add aid 3005 at key (key is under the statue)(NOTE: this key is dialy spawn, not a quest reward).
    Position:(32801, 31579, 6) - Add aid 3006 at key (key is under the fire field)(NOTE: this key is dialy spawn, not a quest reward).
    Position:(32813, 31576, 5) - Add aid 3007 at key (NOTE: this key is dialy spawn, not a quest reward).
    Position:(32800, 31582, 2) - Remove contents (key) - bookcase.
    Fix levers and add last key (3008) chest.lua.

  • • [6.4]Adorned UH Rune Quest
    Switch to kv

  • • [6.4]Barbarian Axe Quest
    Switch to kv

  • • [6.4]Berserker Treasure Quest
    Skipped by mistake

  • • [6.4]Dark Armor Quest
    Switch to kv

  • • [6.4]Demon Helmet Quest
    Done at chest.lua (keep it in storage)

  • • [6.4]Double Hero Quest
    Switch to kv

  • • [6.4]Edron Goblin Quest
    Switch to kv

  • • [6.4]Fire Axe Quest
    Switch to kv

  • • [6.4]Poison Daggers Quest
    Switch to kv

  • • [6.4]Poison Daggers Quest
    Switch to kv

  • • [6.4]Troll Cave Quest
    Switch to kv

  • • [6.4]Vampire Shield Quest
    Position:(33195, 31684, 14) - Remove aid 1070 - door
    Position:(33192, 31691, 14) - Remove uid 9014 - teleport
    Switch to kv

  • • [6.4]Wedding Ring Quest
    Switch to kv

  • • [6.5]Alawar's Vault Quest
    Switch to kv

  • • [6.61-6.97]Iron Hammer Quest
    Position:(32434, 31938, 8) - Remove aid 2000, remove uid 50074, remove contents - box
    Switch to kv

  • • [6.61-6.97]Plate Armor Quest
    Position:(33327, 32182, 7) - Remove aid 5556 - wooden coffin
    Switch to kv

  • • [6.61-6.97]Stealth Ring Quest
    Position:(33315, 32277, 11) - Remove aid 2000, remove uid 50064, remove contents - stone coffin
    Position:(33315, 32282, 11) - Remove aid 2000, remove uid 50065, remove contents - stone coffin
    Switch to kv

  • • [6.61-6.97]Steel Helmet Quest
    Position:(32460, 31951, 5) - Remove aid 2000, remove uid 50070, remove contents - drawers
    Position:(32464, 31957, 5) - Remove aid 2000, remove uid 50071, remove contents - box
    Position:(32462, 31947, 4) - Remove aid 2000, remove uid 50068, remove contents - box
    Position:(32467, 31962, 4) - Remove aid 2000, remove uid 50069, remove contents - chest
    Switch to kv

  • • [6.61-6.97]The Paradox Tower Quest
    I haven't tested.

  • • [7.1]Black Knight Quest
    Position:(32813, 31964, 7) - Remove aid 5558 - dead tree
    Position:(32824, 31969, 8) - Remove aid 5010 - door
    Position:(32874, 31974, 12) - Remove aid 1050 - door
    Position:(32875, 31974, 12) - Remove aid 1050 - door
    Position:(32868, 31955, 11) - Remove aid 2001, remove uid 3027 - dead tree
    Position:(32880, 31955, 11) - Remove aid 2001, remove uid 9055 - dead tree
    Switch to kv

  • • [7.1]Dragon Tower Quest
    Skipped by mistake.

  • • [7.1]Ring Quest
    Switch to kv.

  • • [7.1]Time Ring Quest
    Position:(33038, 32171, 9) - Remove aid 2000, remove uid 50060, remove contents - chest
    Position:(33039, 32171, 9) - Remove aid 2000, remove uid 50061, remove contents - chest
    Position:(33040, 32171, 9) - Remove aid 2000, remove uid 50062, remove contents - chest
    Switch to kv.

  • • [7.2]Behemoth Quest
    Position:(33294, 31658, 13) - Remove aid 2000, remove uid 1298, remove contents - chest
    Position:(33295, 31658, 13) - Remove aid 2000, remove uid 1299, remove contents - chest
    Position:(33297, 31658, 13) - Remove aid 2000, remove uid 1297, remove contents - chest
    Position:(33298, 31658, 13) - Remove aid 2000, remove uid 1296, remove contents - chest
    Position:(33297, 31670, 14) - Remove aid 1080 - door
    Position:(33290, 31715, 12) - Remove uid 2007 - lever
    Switch to kv

  • • [7.24]Mad Mage Room Quest
    Done at Mintwallin Quest

@GuiValladao GuiValladao marked this pull request as ready for review June 10, 2024 16:43
@elsongabriel
Copy link
Contributor

@GuiValladao is all ok?

@GuiValladao
Copy link
Contributor Author

@GuiValladao is all ok?

Yes. Just need the map modifications from my last comment.

@elsongabriel
Copy link
Contributor

@GuiValladao is all ok?

Yes. Just need the map modifications from my last comment.

@phacUFPE when you say ok. we merge.

@phacUFPE
Copy link
Contributor

phacUFPE commented Jun 22, 2024

@GuiValladao is all ok?

Yes. Just need the map modifications from my last comment.

@phacUFPE when you say ok. we merge.

Which map modifications are missing? I did some of the map modifications if not all, but since it was updated, I'll take a look again and apply the new required modifications. When I finish I'll reply this comment with "Done!".

@GuiValladao
Copy link
Contributor Author

@GuiValladao is all ok?

Yes. Just need the map modifications from my last comment.

@phacUFPE when you say ok. we merge.

Which map modifications are missing? I did some of the map modifications if not all, but since it was updated, I'll take a look again and apply the new required modifications. When I finish I'll reply this comment with "Done!".

This ones i believe

"Part 2"

@phacUFPE
Copy link
Contributor

@GuiValladao is all ok?

Yes. Just need the map modifications from my last comment.

@phacUFPE when you say ok. we merge.

Which map modifications are missing? I did some of the map modifications if not all, but since it was updated, I'll take a look again and apply the new required modifications. When I finish I'll reply this comment with "Done!".

Done!

@elsongabriel I left the map with all modifications excluding the recommendations in the Discord.

@htc16
Copy link
Contributor

htc16 commented Jun 27, 2024

I started reviewing it too, if you want help or want to work together on this you can add me on discord. My username: htc_93

I intend to review them all, starting with the first patches...

@htc16
Copy link
Contributor

htc16 commented Jun 27, 2024

[6.4]Berserker Treasure Quest
I tested it and everything is OK

@htc16
Copy link
Contributor

htc16 commented Jun 27, 2024

• [6.61-6.97]The Paradox Tower Quest
There's a bug right at the beginning, I'll correct the script and upload it here. #2719

@htc16 htc16 mentioned this pull request Jun 27, 2024
10 tasks
@htc16
Copy link
Contributor

htc16 commented Jun 29, 2024

I clarify that I did not use this PR as a starting point because it is not loading the uniqueids through the tile.lua file at startup, so I used an original base to correct the quests.

I believe something broke in this PR.

@majestyotbr
Copy link
Contributor

majestyotbr commented Jul 10, 2024

Update your pull request and use the pull request template.

@majestyotbr majestyotbr changed the title Revised Quests fix: revised quests Jul 15, 2024
htc16 added a commit to htc16/canary that referenced this pull request Jul 25, 2024
htc16 added a commit to htc16/canary that referenced this pull request Jul 25, 2024
@majestyotbr
Copy link
Contributor

@majestyotbr majestyotbr changed the title fix: revised quests fix: revised some quests Jul 25, 2024
@majestyotbr majestyotbr merged commit a9c9020 into opentibiabr:main Jul 25, 2024
17 checks passed
@odisk777
Copy link
Contributor

Minotaur Hell Quest
Position:(32130, 32066, 12) - box
Remove aid 2000, remove uid 64127, remove contents.
Position:(32127, 32065, 12) - box
Remove aid 2000, remove uid 64126, remove contents.
Position:(32124, 32064, 12) - box
Remove aid 2000, remove uid 64125, remove contents.

I have a question I was checking the area and several boxes near that one that contain equipment inside also have to be deleted ?
example :
Position {32130, 32055, 12}
Position { 32128, 32066, 12}

@majestyotbr
Copy link
Contributor

Minotaur Hell Quest
Position:(32130, 32066, 12) - box
Remove aid 2000, remove uid 64127, remove contents.
Position:(32127, 32065, 12) - box
Remove aid 2000, remove uid 64126, remove contents.
Position:(32124, 32064, 12) - box
Remove aid 2000, remove uid 64125, remove contents.

I have a question I was checking the area and several boxes near that one that contain equipment inside also have to be deleted ?
example :
Position {32130, 32055, 12}
Position { 32128, 32066, 12}

Yes, it is explained to remove action id, unique id and the content inside the box.

@odisk777
Copy link
Contributor

odisk777 commented Jul 28, 2024

Reports New's

{x = 32053, y = 31939, z = 9} Deleted id y content
{x = 32609, y = 32244, z = 7} deleted ID
{x = 32651, y = 32244, z = 7} Deleted id
{x = 32588, y = 31645, z = 3} deleted id Content

@opentibiabr opentibiabr locked and limited conversation to collaborators Jul 28, 2024
@majestyotbr
Copy link
Contributor

Reports New's

{x = 32053, y = 31939, z = 9} Deleted id y content
{x = 32609, y = 32244, z = 7} deleted ID
{x = 32651, y = 32244, z = 7} Deleted id
{x = 32588, y = 31645, z = 3} deleted id Content

This pull request is already merged, if you want to report something create an issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants