-
-
Notifications
You must be signed in to change notification settings - Fork 652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: revised some quests #2675
fix: revised some quests #2675
Conversation
@phacUFPE can you help, with map modifications? tks. |
Of course, I'll do the modifications when I'll be available. |
@elsongabriel map modifications requested in this PR done! |
I changed the system in "quest_reward_common.lua" so that "chest.lua" would accept quests in kv without the need for an additional script. Unfortunately I'm short on free time so I'm going to leave these changes out of draft and continue the changes in the future.
|
@GuiValladao is all ok? |
Yes. Just need the map modifications from my last comment. |
@phacUFPE when you say ok. we merge. |
Which map modifications are missing? I did some of the map modifications if not all, but since it was updated, I'll take a look again and apply the new required modifications. When I finish I'll reply this comment with "Done!". |
"Part 2" |
Done! @elsongabriel I left the map with all modifications excluding the recommendations in the Discord. |
I started reviewing it too, if you want help or want to work together on this you can add me on discord. My username: htc_93 I intend to review them all, starting with the first patches... |
[6.4]Berserker Treasure Quest |
• [6.61-6.97]The Paradox Tower Quest |
I clarify that I did not use this PR as a starting point because it is not loading the uniqueids through the tile.lua file at startup, so I used an original base to correct the quests. I believe something broke in this PR. |
Update your pull request and use the pull request template. |
Updated global map: |
• Minotaur Hell Quest I have a question I was checking the area and several boxes near that one that contain equipment inside also have to be deleted ? |
Yes, it is explained to remove action id, unique id and the content inside the box. |
Reports New's {x = 32053, y = 31939, z = 9} Deleted id y content |
This pull request is already merged, if you want to report something create an issue. |
I started reviewing some quests listed here.
Because they are simple, I redid most of them in kv, so I will leave the list of changes that need to be made to the map. Most of the changes are removing aid and uid.
If anyone can link the changes to fix :map I would greatly appreciate it! (I'm not good with github).
Newbie Islands Quests:
• Bear Room Quest
Position:(32146, 32097, 11) - chest
Remove aid 2000, remove uid 64116, remove contents.
Position:(32144, 32096, 11) - chest
Remove aid 2000, remove uid 64115, remove contents.
Position:(32141, 32097, 11) - chest
Remove aid 2000, remove uid 64114, remove contents.
Position:(32150, 32112, 12) - chest
Remove aid 2000, remove uid 64113, remove contents.
Position:(32145, 32100, 11) - door
Remove aid 4601.
Position:(32148, 32105, 11) - lever
Remove uid 1056.
Position:(32149, 32110, 11) - trapdoor
Delete and replate to dirt floor id 355.
(Fix the pickaxe path: data-otservbr-global/startup/tables/tile_pick.lua)
• Captain Iglues Treasure Quest
Position:(32039, 32121, 13) - chest
Remove aid 2000 remove uid 64118 remove contents.
• Child of Destiny Quest
It doesn't exist anymore, so I assumed it didn't need to be revised.
• Combat Knife Quest
Position:(32102, 32235, 8)
Remove aid 2000 remove uid 64119.
• Dawnport Quest
-- Mission 'Lost Amulet' --
Fix worms id
Fix questlog misspell.
-- The Stolen Log Book --
Fix questlog misspell.
-- The Rare Herb --
Fix questlog misspell.
-- Tasks --
Fix all 3 tasks count on quest log.
• Doublet Quest
Position:(32084, 32181, 8) - floor
Remove aid 5639.
• Dragon Corpse Quest
Position:(32179, 32224, 9) - dragon corpse
Remove aid 2000, remove uid 64122, remove contents.
• Goblin Temple Quest
Position:(31973, 32209, 12) - chest
Remove aid 2000, remove uid 64123, remove contents.
Position:(31977, 32209, 12) - chest
Remove aid 2000, remove uid 64124, remove contents.
• Katana Quest
Position:(32169, 32157, 8) - random place
Remove random uid 5636.
Position:(32176, 32132, 9) - human corpse
Remove aid 2000, remove uid 64110, remove contents.
Position:(32179, 32149, 10) - door
Remove aid 4693.
Position:(32182, 32145, 11) - level
Remove uid 1054.
Position:(32177, 32148, 11) - door
Remove uid 1055.
Position:(32175, 32145, 11) - human corpse
Remove aid 2000, remove uid, 64112 remove contents.
Position:(32174, 32149, 11) - human corpse
Remove aid 2000, remove uid 64111, remove contents.
• Minotaur Hell Quest
Position:(32130, 32066, 12) - box
Remove aid 2000, remove uid 64127, remove contents.
Position:(32127, 32065, 12) - box
Remove aid 2000, remove uid 64126, remove contents.
Position:(32124, 32064, 12) - box
Remove aid 2000, remove uid 64125, remove contents.
• Rapier Quest
Already done. feat: kv: quests #2099
• Sanctuary of the Lizard God Quest
Tested all OK.
• The Rookie Guard Quest
Fix max level cap - I didn't review the rest yet.
• Tutorial
It doesn't exist anymore, so I assumed it didn't need to be revised.
Newbie Islands Exchange Quests:
• Pick Quest
Tested all OK.
• Present Quest
Position:(32149, 32105, 11) - chest
Remove aid 2000, remove uid 64117, remove contents.
Tested NPC all OK.
• Short Sword Quest
Tested all OK.
• Small Health Potion Quest
Tested all OK.
• Studded Legs Quest
Position:(32005, 32139, 3)
Delete chest and replace to honey flower id 9226 (unmoveble).
Fix script - honey flower.
NPC Tested all OK.
• Studded Shield Quest
Banana Palm Tested all OK.
NPC Tested all OK.
I will try to continue reviewing the quests according to my free time.
Any suggestions, please let me now!