Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: removeBreakWeaponsCharges instead of removeBeginningWeaponAmmunition #2437

Closed
wants to merge 21 commits into from

Conversation

jprzimba
Copy link

  • removeBreakWeaponsCharges now works for all weapons that have break chance

Description

Update break weapown code to work with all break weapons

How Has This Been Tested

Always use on my old Crystal Server

João Paulo and others added 6 commits March 14, 2024 09:41
* removeBreakWeaponsCharges  now works for all weapons that have break chance
Equipping a two-handed weapon using keybind and then unequipping it placed the two-handed weapon in right hand.

The change makes the right hand not a possible slot for a two-handed weapon which forces it to be placed in backpack similar to other equipment.
Warnings when starting the server.
@sebbesiren
Copy link
Contributor

This doesnt solve the same use case as the feature you removed.

Your feature:

  • Removes break chance on everything

The other feature

  • Removed break chance on specific early game ammo (so paladins can use exercise dummy)

@jprzimba
Copy link
Author

jprzimba commented Mar 16, 2024

  • (so paladins can use exercise dummy)

players still use , if using my code

The people involved simply don't want help with the project.
they just want money, doing vakinha and bla bla bla

As the Creator and founder of Crystal server, I would be fully capable of collaborating with the project, but I realize that the people involved only want money.

That's why the project isn't going forward and it's full of bugs..... they're putting the map above the distro.
Where have you seen it? Without a stable server there is no point in having a copy of the global map

@sebbesiren
Copy link
Contributor

With your change all types are affected. With the previous it was only the beginning ammo types etc. Not same feature imo.

@sebbesiren
Copy link
Contributor

And i use the existing feature since i still want players to purchase ammo such as diamond arrows.

luan and others added 14 commits March 17, 2024 17:12
• Initialized variables
• Guaranteed that there is no division by 0, avoiding crash
Added some missing wheel modifiers.
Fixed some wrong wheel slots.
Log moved to trace and fixed a minor error in the deactivation logic.
This update significantly improves the interaction with banking NPCs by addressing the issue where NPCs would drop gold on the ground if a player didn't have enough free slots in their backpack or enough carrying capacity. Now, instead of dropping the gold, the NPC will warn the player about the lack of space or capacity, preventing potential loss of gold. This change ensures a smoother and more intuitive banking experience, keeping players' assets secure and enhancing overall gameplay satisfaction. 

Fixes #2290.

Tested scenarios include withdrawing gold with full backpacks and exceeding carrying capacity, with NPCs now providing warnings instead of dropping gold.
Fix related from the pr: #1494

Resolves #2464
Resolves #2383
The NPC Cledwyn, who performs enchant/recharge of various items in exchange for silver tokens is ALWAYS charging 2 silver tokens for each operation. However, some of them should cost 5 silver tokens.
@jprzimba jprzimba closed this by deleting the head repository Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.