Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: removeBreakWeaponsCharges instead of removeBeginningWeaponAmmunition #2437

Closed
wants to merge 21 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
6e1739e
* removeBreakWeaponsCharges instead of removeBeginningWeaponAmmunition
jprzimba Mar 14, 2024
f2eb82e
fix: typo in savePlayerStorage function (#2435)
luanluciano93 Mar 14, 2024
7d18c43
refactor: move tools to data path (#2434)
omarcopires Mar 14, 2024
cba26d7
fix: two-handed being equipped in right hand on unequip (#2436)
sebbesiren Mar 14, 2024
93b3786
fix: added check for type 'two-handed' (#2410)
Dvineone Mar 14, 2024
50da833
fix: skill duplication on equip item (#2439)
dudantas Mar 14, 2024
af7126a
fix: hazard mount and achievement (#2431)
elsongabriel Mar 16, 2024
d643fba
fix: check if bankable is valid player before emitting metric (#2453)
luan Mar 17, 2024
e9e9967
fix: global server save and expBoostCount improvements (#2449)
elsongabriel Mar 18, 2024
bb886a4
fix: sonar bugs related to uninitialized variable (#2462)
dudantas Mar 18, 2024
0346955
fix: two-handed weapons attributes (#2461)
dudantas Mar 18, 2024
39d0d84
fix: wheel bugs (#2417)
dudantas Mar 18, 2024
4a661ef
fix: register weapon with chain attribute (#2421)
dudantas Mar 18, 2024
1e70b57
improve: banking NPC behavior for gold withdraw (#2414)
lamonato29 Mar 18, 2024
cb30f3f
fix: correct configure weapon wand (#2465)
dudantas Mar 18, 2024
18ec4a7
fix: incorrect pricing for enchant/recharge with silver tokens (#2463)
CarlosE-Dev Mar 19, 2024
944c74b
fix: set isBlocking to false for area runes (#2468)
Aerwix Mar 19, 2024
b0493f7
Update items.xml
jprzimba Mar 19, 2024
36173a3
Merge branch 'main' of https://github.com/jprzimba/canary
jprzimba Mar 19, 2024
05ee87f
Update items.xml
jprzimba Mar 19, 2024
26ec27f
Merge branch 'main' of https://github.com/jprzimba/canary
jprzimba Mar 19, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions config.lua.dist
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ maintainModeMessage = ""

-- Combat settings
-- NOTE: valid values for worldType are: "pvp", "no-pvp" and "pvp-enforced"
-- NOTE: removeBeginningWeaponAmmunition: spears, arrows, bolt have endless ammo (allows training for paladins)
-- NOTE: removeBreakWeaponsCharges: Does not remove weapon charges with a chance of breaking. Like Viper Star, Spear
-- NOTE: refundManaOnBeginningWeapons: wand of vortex and snakebite refund mana used (allows training for mages)
worldType = "pvp"
hotkeyAimbotEnabled = true
Expand All @@ -33,7 +33,7 @@ removeChargesFromRunes = true
removeChargesFromPotions = true
removeWeaponAmmunition = true
removeWeaponCharges = true
removeBeginningWeaponAmmunition = true
removeBreakWeaponsCharges = true
refundBeginningWeaponMana = false
timeToDecreaseFrags = 24 * 60 * 60 * 1000
whiteSkullTime = 15 * 60 * 1000
Expand Down
8 changes: 0 additions & 8 deletions data-canary/scripts/actions/tools/crowbar.lua

This file was deleted.

8 changes: 0 additions & 8 deletions data-canary/scripts/actions/tools/machete.lua

This file was deleted.

8 changes: 0 additions & 8 deletions data-canary/scripts/actions/tools/pick.lua

This file was deleted.

8 changes: 0 additions & 8 deletions data-canary/scripts/actions/tools/rope.lua

This file was deleted.

8 changes: 0 additions & 8 deletions data-canary/scripts/actions/tools/scythe.lua

This file was deleted.

8 changes: 0 additions & 8 deletions data-canary/scripts/actions/tools/shovel.lua

This file was deleted.

8 changes: 0 additions & 8 deletions data-canary/scripts/actions/tools/spoon.lua

This file was deleted.

8 changes: 6 additions & 2 deletions data-otservbr-global/npc/cledwyn.lua
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,8 @@ end

local charge = {}

local chargePrice = {}

local chargeItem = {
["pendulet"] = { noChargeID = 29429, ChargeID = 30344 },
["sleep shawl"] = { noChargeID = 29428, ChargeID = 30342 },
Expand Down Expand Up @@ -137,18 +139,20 @@ local function creatureSayCallback(npc, creature, type, message)
elseif table.contains({ "pendulet", "sleep shawl", "blister ring", "theurgic amulet", "ring of souls", "turtle amulet" }, message:lower()) and npcHandler:getTopic(playerId) == 1 then
npcHandler:say("Should I enchant the item " .. message .. " for 2 " .. ItemType(npc:getCurrency()):getPluralName():lower() .. "?", npc, creature)
charge = message:lower()
chargePrice = 2
npcHandler:setTopic(playerId, 2)
elseif table.contains({ "spiritthorn ring", "alicorn ring", "arcanomancer sigil", "arboreal ring" }, message:lower()) and npcHandler:getTopic(playerId) == 1 then
npcHandler:say("Should I enchant the item " .. message .. " for 5 " .. ItemType(npc:getCurrency()):getPluralName():lower() .. "?", npc, creature)
charge = message:lower()
chargePrice = 5
npcHandler:setTopic(playerId, 2)
elseif npcHandler:getTopic(playerId) == 2 then
if MsgContains(message, "yes") then
if not chargeItem[charge] then
npcHandler:say("Sorry, you don't have an unenchanted " .. charge .. ".", npc, creature)
else
if (player:getItemCount(npc:getCurrency()) >= 2) and (player:getItemCount(chargeItem[charge].noChargeID) >= 1) then
player:removeItem(npc:getCurrency(), 2)
if (player:getItemCount(npc:getCurrency()) >= chargePrice) and (player:getItemCount(chargeItem[charge].noChargeID) >= 1) then
player:removeItem(npc:getCurrency(), chargePrice)
player:removeItem(chargeItem[charge].noChargeID, 1)
local itemAdd = player:addItem(chargeItem[charge].ChargeID, 1)
npcHandler:say("Ah, excellent. Here is your " .. itemAdd:getName():lower() .. ".", npc, creature)
Expand Down
7 changes: 4 additions & 3 deletions data-otservbr-global/npc/gnomadness.lua
Original file line number Diff line number Diff line change
Expand Up @@ -83,12 +83,13 @@ local function creatureSayCallback(npc, creature, type, message)
end
if hazard:setPlayerCurrentLevel(player, desiredLevel) then
npcHandler:say("Your hazard level has been set to " .. desiredLevel .. ". Good luck!", npc, creature)
if desiredLevel >= hazard.maxLevel and not player:kv():scoped("primal-ordeal"):get("received-prize") then
player:sendTextMessage(MESSAGE_EVENT_ADVANCE, "Congratulations you received the Noxious Ripptor mount.")
if desiredLevel >= 6 and not player:kv():scoped("primal-ordeal"):get("received-prize") then
player:addMount(202)
npcHandler:say("You've achived the maximum hazard level. As a reward, you've received the Noxious Ripptor mount and a primal bag.", npc, creature)
player:sendTextMessage(MESSAGE_EVENT_ADVANCE, "Congratulations you received the Noxious Ripptor mount.")
player:addAchievement("Ripp-Ripp Hooray!")
player:addItem(PRIMAL_BAG, 1)
player:kv():scoped("primal-ordeal"):set("received-prize", true)
npcHandler:say("You've achieved the necessary hazard level. As a reward, you've received the Noxious Ripptor mount and a primal bag.", npc, creature)
end
else
npcHandler:say("You can't set your hazard level higher than your maximum unlocked level.", npc, creature)
Expand Down
Loading
Loading