Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: imbuements system #2494

Closed
wants to merge 8 commits into from
Closed

Conversation

beats-dh
Copy link
Collaborator

Description

@beats-dh beats-dh force-pushed the refactor-imbuements-system branch 3 times, most recently from 928b6fb to a22f39a Compare March 27, 2024 01:16
@elsongabriel elsongabriel marked this pull request as draft March 27, 2024 23:54
@beats-dh beats-dh force-pushed the refactor-imbuements-system branch from a94b882 to 79a0ef8 Compare March 28, 2024 00:00
@beats-dh beats-dh marked this pull request as ready for review March 31, 2024 23:34
@elsongabriel elsongabriel self-requested a review April 3, 2024 18:39
@elsongabriel elsongabriel mentioned this pull request May 4, 2024
7 tasks
@rokamdev
Copy link

rokamdev commented May 7, 2024

I added these changes but all the other imbues stopped working or had their bonuses wrong.
Axe imbue, giving +100 skill, club working correctly and all others without any bonus.
I had already uploaded this pull before it was approved and had the same error, thinking that something might have gone unnoticed. But now after it was approved I had the same problem.

@Zapotoczny
Copy link

Zapotoczny commented May 8, 2024

  1. when changing the engine, with or without changes, bonuses change
  2. leech and critical do not work

@beats-dh beats-dh force-pushed the refactor-imbuements-system branch from 79a0ef8 to 1a45dbe Compare May 13, 2024 16:46
@beats-dh
Copy link
Collaborator Author

@Zapotoczny @rokamdev @elsongabriel: Test again

@Chapeleiiro
Copy link
Contributor

Chapeleiiro commented May 31, 2024

You see a jungle rod (Atk:55, magic level +1, protection earth +3%).
It can only be wielded properly by druids of level 150 or higher.
Imbuements: (Basic Scorch 19:43h, Empty Slot).
Classification: 4 Tier: 0
It weighs 37.00 oz.
Client ID: 35521
Position: (65535, 66, 1)

You see a jungle rod (Atk:55, magic level +1, protection earth +3%).
It can only be wielded properly by druids of level 150 or higher.
Imbuements: (Powerful Strike 20:00h, Empty Slot).
Classification: 4 Tier: 0
It weighs 37.00 oz.
Client ID: 35521
Position: (65535, 66, 0)

The item changed the attribute when the server closed. It changed from critical to Scorch and started giving this log warning
and it couldn't be imbued with a chop
[2024-31-05 05:23:01.179] [warning] Imbuement 18 not found
[2024-31-05 05:23:01.179] [warning] Imbuement 21 not found

I noticed that all items are Powerful and turned into basic. This backpack is one that also gave an error
image
image

@@ -3,7 +3,7 @@ combat:setParameter(COMBAT_PARAM_EFFECT, CONST_ME_MAGIC_RED)
combat:setParameter(COMBAT_PARAM_TYPE, COMBAT_UNDEFINEDDAMAGE)

local condition = Condition(CONDITION_PARALYZE)
condition:setParameter(CONDITION_PARAM_TICKS, 6000)
condition:setParameter(CONDITION_PARAM_TICKS, 60000)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

undo this.

Comment on lines +32 to +33
rune:cooldown(1 * 1000)
rune:groupCooldown(1 * 1000)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

undo these lines.

@majestyotbr
Copy link
Contributor

majestyotbr commented Jul 10, 2024

Update your pull request and use the pull request template.

@majestyotbr
Copy link
Contributor

I'm closing this pull request due to inactivity. Feel free to reopen when you decide to finish.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants