Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: monsters and npcs spawns #2824

Merged
merged 3 commits into from
Aug 19, 2024
Merged

fix: monsters and npcs spawns #2824

merged 3 commits into from
Aug 19, 2024

Conversation

majestyotbr
Copy link
Contributor

@majestyotbr majestyotbr commented Aug 16, 2024

Description

Fix monsters and npcs spawns.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Test Configuration:

  • Server Version: 3.1.2
  • Client: 13.40
  • Operating System: Windows

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

Copy link
Contributor

github-actions bot commented Aug 16, 2024

Qodana for C/C++

1 new problem were found

Inspection name Severity Problems
function-cognitive-complexity 🔶 Warning 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/[email protected]
        with:
          upload-result: true
Contact Qodana team

Contact us at [email protected]

@majestyotbr majestyotbr marked this pull request as draft August 17, 2024 15:19
@majestyotbr majestyotbr marked this pull request as ready for review August 19, 2024 01:41
@majestyotbr majestyotbr merged commit 88a4db9 into main Aug 19, 2024
27 checks passed
@majestyotbr majestyotbr deleted the spawns branch August 19, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Map issues, sprite changes and npc missing items. Soul Wars ebb and flow
2 participants