Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wrong packet in protocol 11.00 (sendSaleItemList) #2837

Merged
merged 4 commits into from
Aug 26, 2024

Conversation

kokekanon
Copy link
Contributor

@kokekanon kokekanon commented Aug 21, 2024

Description

to reproduce: login in protocol 11.00 OTC redemption /goto Xodet .
say hi trade when windows appears , error in console

ProtocolGame parse message exception (1709 bytes, 0 unread, last opcode is 0x00 (0), prev opcode is 0x7b (123), proto: 1100): unhandled opcode 0

test in 13.40 and 11.00 otclient redemption

13 40v

Fixes

"Problem with the list of items in the NPC trade in the old protocol"
#2840

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Test Configuration:

  • Server Version: canary last commits : fix: monsters and npcs spawns
  • Client: OTC redemption 11.00
  • Operating System: Windows 10+1

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@luanluciano93

This comment was marked as resolved.

@majestyotbr majestyotbr linked an issue Aug 22, 2024 that may be closed by this pull request
5 tasks
@majestyotbr majestyotbr merged commit 89ce6c4 into opentibiabr:main Aug 26, 2024
22 checks passed
s2leandro155 pushed a commit to s2leandro155/rzyns that referenced this pull request Sep 26, 2024
@kokekanon kokekanon mentioned this pull request Oct 19, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem with the list of items in the NPC trade in the old protocol
4 participants