Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new augments and update item description (amber items) #2900

Merged
merged 16 commits into from
Oct 31, 2024

Conversation

phacUFPE
Copy link
Contributor

@phacUFPE phacUFPE commented Sep 18, 2024

Description

This PR updates the augments to be able to handle the substitution of the Increase Damage, Strong Impact and Powerful Impact into Base Damage and Base Healing. It also adds the new item description to handle the new Amber Items with elemental attack greater than 0 and physical attack value equal 0.

Behaviour

Actual

  1. Try adding the value "base" as an augment and nothing should happen.
  2. Try add the attack value to 0 and set some elemental damage, the atk with the elemental damage will not be displayed.

Expected

Do the same behavior as listed in the Actual section and it should all work.

Fixes #2895

Type of change

Please delete options that are not relevant.

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Add base value as an augment with the value of 100 and check if the value of a healing spell or attack spell doubles the attack or healing depending on the spell set in the augment
  • Look into a weapon with the attack set as 0 or not set and an ice elemental attack set to 50, it should appear like "(Atk: 0 physical + 50 ice"
  • Do the same as the previous test and check the item cyclopedia inspect and market details.

Test Configuration:

  • Server Version: Latest (main)
  • Client: 13.40
  • Operating System: Windows

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

Copy link
Contributor

@FelipePaluco FelipePaluco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

data/items/items.xml Outdated Show resolved Hide resolved
src/items/item.cpp Outdated Show resolved Hide resolved
@rokamdev

This comment was marked as resolved.

@phacUFPE phacUFPE force-pushed the phacUFPE/new_augments branch from b50fc47 to cd534af Compare September 24, 2024 02:19
Copy link

@rokamdev rokamdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! Everything working correctly!

@W4gNII
Copy link

W4gNII commented Sep 27, 2024

good all work!

@opentibiabr opentibiabr deleted a comment from github-actions bot Oct 31, 2024
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
19.1% Duplication on New Code (required ≤ 10%)

See analysis details on SonarCloud

@dudantas dudantas merged commit ff57174 into main Oct 31, 2024
43 of 44 checks passed
@dudantas dudantas deleted the phacUFPE/new_augments branch October 31, 2024 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Augment Configuration
8 participants