fix: quests from version 11 revised

[htc16]

Description

• 11.02 - Festive Outfits Quest
• 11.02 - Forgotten Knowledge Quest

At position (32454, 32115, 7) change port id 6251 to port id 6252
at position {x = 31978, y = 32852, z = 14} the vortex goes to {x = 31975, y = 32858, z = 15}
at position {x = 31977, y = 32861, z = 15} the vortex goes to {x = 31981, y = 32850, z = 14}
at position {x = 31978, y = 32842, z = 14} the vortex goes to {x = 31975, y = 32842, z = 15}
at position {x = 31977, y = 32845, z = 15} the vortex goes to {x = 31981, y = 32843, z = 14}
at position {x = 31994, y = 32842, z = 14} the vortex goes to {x = 31992, y = 32842, z = 15}
at position {x = 31993, y = 32845, z = 15} the vortex goes to {x = 31991, y = 32844, z = 14}
at position {x = 31994, y = 32852, z = 14} the vortex goes to {x = 31991, y = 32858, z = 15}
at position {x = 31993, y = 32861, z = 15} the vortex goes to {x = 31991, y = 32850, z = 14}

• 11.02 - The First Dragon Quest

In this position (33598, 30996, 12) you need to fill in item 1128, as it is obstructing the view below.
At position (33597, 30996, 14) remove the actionid that exists in this teleport as I will go up through tables.
At position (33583, 30992, 14) remove the actionid and uniqueid, as this is already set at initialization by the table.
At position (33584, 31004, 15) this line appears on the screen when you are in the lever room.

• 11.40 - Cults of Tibia Quest

At position (32723, 31582, 8) there is an error in the tile.
at position (32736, 31450, 8) has item id 837, replace with id 27866.
at position (32736, 31451, 8) has item id 837, replace with id 27866.
at position (32736, 31452, 8) has item id 840, replace with id 25739.
At position (32761, 31523, 9) replace port id 5115 with 5116
In area (33188, 31894, 15), you need to close the black side of the client screen.
at position (33131, 31920, 8) you need to fill in to not display this on the floor below.
at position (33173, 31834, 15) you need to fill in to avoid displaying a black screen on the client.
at position (33155, 31860, 15) a black line and a gray line appear on the client.

• 11.40 - Threatened Dreams Quest

Delete the npc and area at position (10253, 10033, 1)
At position {x = 33829, y = 32187, z = 14} put actionid 0
At position {x = 33982, y = 32234, z = 14} put actionid 0
At position {x = 33831, y = 32138, z = 14} put actionid 0
At position {x = 34021, y = 32037, z = 14} put actionid 0
At position {x = 33784, y = 32205, z = 14} put actionid 0
At position {x = 33921, y = 32402, z = 14} put actionid 0

• 11.50 - Dangerous Depths Quest
• 11.50 - Hidden Threats Quest
• 11.50 - Makeshift Warrior Outfits Quest
• 11.80 - Battle Mage Outfits Quest
• 11.80 - Measuring Tibia Quest (You need to develop this quest)
• 11.80 - The Secret Library Quest (It is only necessary to develop part 2 of this quest.)
• Quests have been tested in development!

I'm currently working on adding all quests to the PR. Given the large number of quests, I would like to ask for your help and collaboration to close this PR as quickly as possible. If you are interested in helping, choose one of the quests to review, open a PR for it, and link to this PR. All help is welcome!

Note1: my focus is on quests, therefore, the quest log for a quest may be missing as this is not shown in the quest tutorial lists. I study tutorials and release fix ones or develop something related to the tutorial.

Note2: I have limitations as this is the first time I am willing to do this, so please consider that some codes may not be the best but what matters is the intention and this can be improved in the future if someone finds it appropriate to do so.

Note3: I'm taking the opportunity to catalog all the aids and uids so that we can eventually modify and change them in the future directly through the script.

Note4: this PR needs some updates to the map that were reported above.

Note5: I was unable to place the writings in the books, only through the map editor, but this did not influence the development of the quest, so I left this for a future review.

Behavior

Real

I reviewed and corrected any quests that weren't working.

Delete options that are not relevant.

• Bug fix (rolling change that fixes a problem)
• New feature (rolling change that adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)

How this was tested

As I reviewed and modified the codes, I tested them.

Test Setup:

• Server version: current
• Client: 13
• Operating system: Windows 11

Checklist

• My code follows the style guidelines of this project
• I performed a self-review of my own code
• I checked the PR checks reports
• I commented my code, especially in areas that were difficult to understand
• I made corresponding changes to the documentation
• My changes do not generate new warnings
• I added tests that prove my fix is ​​effective or that my feature works

[murilo09]

I've converted the PR to Draft while it's in development.

[Glatharth]

The levers for the bosses are on an old and non-standard model, they need to be standardized to make it easier to maintain and implement future features. I'm going to make the lib available so that you can be set up with the new standard. In the file there is an example of how the “config” table works with all the resources you'll need. I will also provide some examples of levers that use the “onUseExtra” resource for extra resources.
lib
Example 1
Example 2

[htc16]

The levers for the bosses are on an old and non-standard model, they need to be standardized to make it easier to maintain and implement future features. I'm going to make the lib available so that you can be set up with the new standard. In the file there is an example of how the “config” table works with all the resources you'll need. I will also provide some examples of levers that use the “onUseExtra” resource for extra resources. lib Example 1 Example 2

At this time I will keep the levers as they are, since they have been tested and are working as expected for the quest. Nothing prevents this from being updated if necessary in the future. There has already been extensive discussion about this.

[Glatharth]

Fortunately, the bossLever system is linked to several other systems and it is extremely important that it works, although it is not implemented in all the project's code, it does not mean that it should not be implemented. I've implemented the systems, but I don't have permission to push them to your repository, but you can review them and merge them into your repository. I'm not sure if all the levers are in the default, if there are any missing, you can implement them.

https://github.com/Glatharth/canary/tree/Review-Quests-V12

A few points to consider:

• Timer Storage: bossLever doesn’t use storage to track time, so the timer storage won’t function as expected and should be adjusted. I’ve provided an example using Oberon as a reference if needed.

In the code files I modified, I’ve left some notes:

• ferumbras_ascension/actions_ferumbras_lever.lua

  • Updated the crystal IDs as they were incorrect. A question remains: are these crystals ever swapped? If so, ensure the IDs are accurate; otherwise, the loop may be redundant and should be removed.
  • Why use globalStorage if it’s not utilized anywhere else?

• liquid_death/movements_bossWay.lua

  • This script doesn't work, need to check if map has changed

If I'm wrong somewhere you can correct me, I haven't checked everything, they're just observations.

[murilo09]

@htc16 could you check the files @Glatharth provided?

[htc16]

Fortunately, the system is linked to several other systems and it is extremely important that it works, although it is not implemented in all the project's code, it does not mean that it should not be implemented. I've implemented the systems, but I don't have permission to push them to your repository, but you can review them and merge them into your repository. I'm not sure if all the levers are in the default, if there are any missing, you can implement them.bossLever

https://github.com/Glatharth/canary/tree/Review-Quests-V12

A few points to consider:

• Timer Storage: doesn’t use storage to track time, so the storage won’t function as expected and should be adjusted. I’ve provided an example using Oberon as a reference if needed.bossLever``timer

In the code files I modified, I’ve left some notes:

• ferumbras_ascension/actions_ferumbras_lever.lua

  • Updated the crystal IDs as they were incorrect. A question remains: are these crystals ever swapped? If so, ensure the IDs are accurate; otherwise, the loop may be redundant and should be removed.
  • Why use if it’s not utilized anywhere else?globalStorage

• liquid_death/movements_bossWay.lua

  • This script doesn't work, need to check if map has changed

If I'm wrong somewhere you can correct me, I haven't checked everything, they're just observations.

I will not retest everything I have already done, if you want to bring this to this PR feel free or wait for the PR to be merged and make a bosslever PR. Thank you.

@murilo09

[majestyotbr]

Updated global map:
https://github.com/opentibiabr/canary/releases/download/v3.1.0/otservbr.otbm

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud