-
Notifications
You must be signed in to change notification settings - Fork 434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UCP/WIREUP: Don't discard CM lane #5882
Merged
yosefe
merged 1 commit into
openucx:master
from
dmitrygx:topic/ucp/do_not_discard_cm_lane
Nov 9, 2020
Merged
UCP/WIREUP: Don't discard CM lane #5882
yosefe
merged 1 commit into
openucx:master
from
dmitrygx:topic/ucp/do_not_discard_cm_lane
Nov 9, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitrygx
force-pushed
the
topic/ucp/do_not_discard_cm_lane
branch
from
November 5, 2020 15:48
bfb2958
to
804c72e
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
The failure is unrelated |
@brminich @evgeny-leksikov @alinask could you review pls? |
evgeny-leksikov
approved these changes
Nov 6, 2020
brminich
approved these changes
Nov 6, 2020
@yosefe could you review pls? |
yosefe
reviewed
Nov 6, 2020
yosefe
reviewed
Nov 6, 2020
yosefe
reviewed
Nov 6, 2020
yosefe
approved these changes
Nov 7, 2020
dmitrygx
force-pushed
the
topic/ucp/do_not_discard_cm_lane
branch
from
November 7, 2020 14:10
b3cd7e8
to
45d4775
Compare
can this be related?
|
@yosefe thank you for pointing me out |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Don't discard CM lane.
Why ?
Don't schedule UCT CM lane to be discarded, since UCP EP will be destroyed due to peer failure and
ucp_cm_disconnect_cb()
could be invoked on async thread after UCP EP is destroyed and before UCT CM EP is destroyed from discarding functionality. So, UCP EP will passed as a corrupted argument toucp_cm_disconnect_cb()
.Fixes #5875
How ?
Add
if
check into theucp_worker_iface_err_handle_progress()
to understand whether the lane is CM or not:uct_ep_pending_purge()
and destroy UCT EP in-place by callinguct_ep_destroy()