-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
discard unused uct_ep when the pre-created uct_ep more than needed #223
Conversation
bb99ed5
to
8a10332
Compare
8a10332
to
95dc3d9
Compare
|
95dc3d9
to
8bb6068
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
How to run the below
|
take care of the direcotry
|
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
@yosefe Is it possible to review this PR before fixing the CI self problem? |
CI has been passed. |
@dmitrygx can you pls review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@changchengx did you use the latest code from master?
I see that some bugs came from the initial implementation.
So, I suggest you align this PR with the master branch.
@dmitrygx I've followed your 1st round CR comments to refine the implmentation. Please check it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shall we add ucp_worker_discard_uct_ep_cleanup
to cleanup discarding hash in ucp_worker_destroy
?
As we've talked offline, I'll add warning if the |
@yosefe Dmitry has approved this PR and he's in Hackathon these days. |
@yosefe Do you have any comments about this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we add CI to test this?
this branch has minimal ci infrastructure to run io_demo
@yosefe Do you mean to add test into |
2 short tests in io-demo.yaml , without interference, with different num_paths (2->1 and 1->2) |
@yosefe Does azure CI stop working? There's no CI triggered here. |
Two test cases have been added. |
@changchengx pls squash |
Signed-off-by: Changcheng Liu <[email protected]>
What
keep NUM_PATHS compatible between server (e.g. UCX_IB_NUM_PATHS=1) and client (e.g. UCX_IB_NUM_PATHS=2)
This PR is mainly ported from: