Refactor lookup-by-value, fix a bug, and add unit tests #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also fixes a bug that while ParselessPhraseDB's reverse lookup uses prefix match, actual lookup-by-value in ParselessLM shouldn't use prefix match.
lukhnos
added a commit
to openvanilla/fcitx5-mcbopomofo
that referenced
this pull request
Oct 4, 2023
lukhnos
added a commit
to openvanilla/fcitx5-mcbopomofo
that referenced
this pull request
Oct 4, 2023
zonble
approved these changes
Oct 4, 2023
lukhnos
added a commit
to openvanilla/fcitx5-mcbopomofo
that referenced
this pull request
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@shuang886 I refactored the code introduced in #372 and I fixed an issue. While the parseless db uses prefix match for looking up keys by value, the actual parseless LM shouldn't use prefixes.
To reproduce the issue, edit manually
data.txtto make the term 鑰匙圈 have a higher score than 鑰匙 (say -1.0), then try to add the phrase 鑰匙系統 via the system service. It turns out that without the fix, the reading ㄧㄠˋ-ㄕˊ-ㄑㄩㄢ-ㄒㄧˋ-ㄊㄨㄥˇ is added. It's just that 鑰匙圈 normally has a score way lower than 鑰匙, and so this bug doesn't manifest itself easily.