Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cr conditions #14

Conversation

OchiengEd
Copy link
Contributor

Description of the change:

Given it is possible for a custom resource to be in error / failed state while a new reconcile process is ongoing, it is unnecessary to mark the status of previous Failure conditions to False while the reconcile loop is still running.

The failure condition will be removed when the custom resource is successfully deployed as it works today.

Motivation for the change:

The failure conditions have timestamps and are accurate as at the time of reporting. Therefore, it would be unnecessary and misleading to set the failure condition status to False before the custom resource is successfully deployed.

Checklist

If the pull request includes user-facing changes, extra documentation is required:

Changelogs will be generated from git commits while documentation will
still be contained in the main Operator SDK repository

Signed-off-by: Edmund Ochieng <[email protected]>
@everettraven everettraven linked an issue Oct 5, 2023 that may be closed by this pull request
Copy link
Collaborator

@everettraven everettraven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this PR has a messed up rebase? There are some changes that, from what I can tell, already exist on main

Signed-off-by: Edmund Ochieng <[email protected]>
Previous failure condition status is set to false when subsequent reconcile begins.
This is unnecessary since the conditions are true at the time of
reporting.

The failure condition can however, be reset when reconcile
completes successfully.

Signed-off-by: Edmund Ochieng <[email protected]>
@OchiengEd OchiengEd force-pushed the update_cr_conditions branch from 0d96212 to e8de6f3 Compare October 9, 2023 15:20
@OchiengEd OchiengEd closed this Oct 11, 2023
@OchiengEd OchiengEd deleted the update_cr_conditions branch October 11, 2023 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ansible-operator] Status false when type/reason = Successful
2 participants