Skip to content

Commit

Permalink
Move asset pipeline javascripts to frontend (#8482)
Browse files Browse the repository at this point in the history
* ove reporting and reporting_engine js to frontend page

* Replace webhook assets javascript

* Add path augment service to dynamically load scripts

* Remove JS-Files that are not used/not needed any more

* Include AugmentingModule correctly

* Remove special handling for checkbox selection which is outdated and two jquery libs that are not used any more

* Load scripts dynamically that are not needed globally

* Move plugin JS to frontend

* Move toggable fieldsets to global listeners

* Move top-menu to global listeners and convert to TS

* Move action_menu to frontend and port to TS

* Move settings listener to frontend

* Remove global js assets that were not used anyway

* Move date range to timelog dynamic script where it's still used until removed

* Move colors to global-listeners and port to TS

* Replace tooltip with simple form instructions on the one place used

Tooltips were only used at the one place in our application, when changing a users password.
We can simply remove it there and use a modern solution the next time we need a tooltip

* Move danger zone validation to frontend and port to TS

* Move colorcontrast to backlogs vendor where it's used now

* Remove contents of application.js.erb

* Move project and user scripts to dynamically loaded

* Move onboarding tour to dynamically loaded

* Use correct syntax for jQuery so that $ is  known keyword within this function

* Fix onboarding tour

* Fix onboarding tour for scrum tour

* Fix specs after moving JS

* Remove application.js.erb

* Move locales and ckeditor to the frontend to dynamically load

* Remove bundles caches

These are no longer being used since angular cli

* Ensure locales are exported before angular

Co-authored-by: Henriette Darge <[email protected]>
  • Loading branch information
oliverguenther and HDinger authored Jul 9, 2020
1 parent 97fad89 commit 10e2115
Show file tree
Hide file tree
Showing 206 changed files with 1,926 additions and 4,915 deletions.
2 changes: 1 addition & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,9 @@ npm-debug.log*
/backup
/.project
/.loadpath
/app/assets/javascripts/bundles/*.*
/app/assets/javascripts/editor/*
/app/assets/javascripts/locales/*.*
/frontend/src/locales/*.js
/config/additional_environment.rb
/config/configuration.yml
/config/database.yml
Expand Down
3 changes: 0 additions & 3 deletions .jshintignore
Original file line number Diff line number Diff line change
@@ -1,5 +1,2 @@
app/assets/javascripts/date-de-DE.js
app/assets/javascripts/date-en-US.js
app/assets/javascripts/jquery_noconflict.js
app/assets/javascripts/project/**/*
app/assets/javascripts/lib/**/*
3 changes: 1 addition & 2 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,7 @@ cache:
bundler: true
directories:
- public/assets
- app/assets/javascripts/bundles
- app/assets/javascripts/locales
- frontend/src/locales

branches:
only:
Expand Down
3 changes: 0 additions & 3 deletions Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,6 @@ PATH
remote: modules/reporting
specs:
openproject-reporting (1.0.0)
jquery-tablesorter (~> 1.27.0)
openproject-costs
reporting_engine

Expand Down Expand Up @@ -559,8 +558,6 @@ GEM
iso8601 (0.12.1)
jaro_winkler (1.5.4)
jmespath (1.4.0)
jquery-tablesorter (1.27.1)
railties (>= 3.2)
json (2.3.0)
json-jwt (1.11.0)
activesupport (>= 4.2)
Expand Down
100 changes: 0 additions & 100 deletions app/assets/javascripts/action_menu.js

This file was deleted.

Loading

0 comments on commit 10e2115

Please sign in to comment.