Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat[Op#23673]: Merge btey/openproject-gitlab-integration 🎉 #14881

Merged
merged 121 commits into from
Mar 6, 2024
Merged

feat[Op#23673]: Merge btey/openproject-gitlab-integration 🎉 #14881

merged 121 commits into from
Mar 6, 2024

Conversation

akabiru
Copy link
Member

@akabiru akabiru commented Feb 28, 2024 •
edited
Loading

https://community.openproject.org/projects/openproject/work_packages/23673

btey/openproject-gitlab-integration#59

Purpose:

The goal of this integration is to make GitLab's units of work (merge requests and issues) manageable from within OpenProject by

  1. Linking GitLab's merge requests with work packages and
  2. Linking GitLab's issues with work packages

Integration Tasks

  • Code review of the existing GitLab plugin
  • Check security aspects
  • Change URL to repo in plugin overview /admin/plugins
    • Bump version to 3.0.0 to prevent clashes
    • Update gemspec authors to include OpenProject and Ben Tey
    • Review /admins/plugins page
  • Come up with a migration path for existing plugin installations (OP#53297)
    • Migrations check that they don't conflict with previous plugin integrations
  • Write tests Implementation/53117 Add automated tests for the critical path of gitlab integration #14899
    • (Only the most vital ones. Keeping in mind that this code is already in production on some people's servers. It should work.)
    • Add setup documentation for admins. (Op#53299)
    • Update module README.md
    • Consolidate with GitHub integration and remove code duplication, wherever it is worth it.
  • Clarify LICENSE update from btey/openproject-gitlab-integration

Out of scope:

  • Full test coverage
  • Adoption of Primer design system
  • Further features

btey and others added 30 commits March 15, 2021 11:20
@btey
Initial commit
e46a889
@btey
Initial release
3ccf3fa
@btey
Initial readme
5493951
@btey
Update README.md
cb0949a
New images for readme.
af35aa6
Merge branch 'master' of https://github.com/btey/openproject-gitlab-i…
58279c7 
…ntegration
@btey
Updated Readme
e992ca8
@btey
Update README.md
12d65f0
Pre-release version with copyright
06ca5d3
Merge branch 'master' of https://github.com/btey/openproject-gitlab-i…
f4b5dc0 
…ntegration
@btey
Update README.md
68ea542
Fixes based on github plugin for v12
4c78ed6
Merge tag 'v2.0.1' into develop
a19f15f 
no message
Merge branch 'hotfix/v2.0.1'
fe4eb8b
Better place for setup IDs of WP Status
8297f54
Merge branch 'release/v2.0.2'
5ab410c
@oliverguenther
Remove requiring changes to the OpenProject core
c6b753a
@oliverguenther @btey
Apply suggestions from code review
f86cd0c 
Co-authored-by: btey <[email protected]>
@btey
Merge pull request #6 from oliverguenther/fix/overrides
2cef1b3 
Remove requiring changes to the OpenProject core
@btey
Update README.md
ab70705 
Update version in Readme.
@btey
Update README.md
3763aa2 
Set this version as stable.
@btey
Update README.md
dcf7342 
Add the necessary dependency to Gemfile.lock which was missing in the Readme.
@btey
Updating Readme for Docker setup
fbfcfce 
Updating Readme referencing official OpenProject Docker documentation
@oliverguenther
Don't try to output link on new record
df92416
@btey
Merge pull request #11 from oliverguenther/fix/wp-new-record
451cbf9 
Don't try to output link on new record
@BjoernLudwigPTB
Update README with current link to GitHub integration docs
e0d2b03
@btey
Merge pull request #12 from BjoernLudwigPTB/correct_link_to_important…
6c9fdb6 
…_github_integration_docs

Update README with current link to GitHub integration docs
@btey
Updated README.md
23c7855 
Some updates and fixes from the community. Thank you all!
Fix compatibility with OP permission arguments
9139898
Fix APIV3Service library name change
1090e20
@akabiru akabiru force-pushed the implementation/53019-bring-bteyopenproject-gitlab-integration-into-a-structure-that-matches-openproject branch from 1a70966 to e3c4388 Compare March 2, 2024 12:40
akabiru added 12 commits March 4, 2024 15:14
@akabiru
chore[Op#53117]: build ci details from dynamic factory
4c81e63
@akabiru
tests[Op#53117]: add gitlab merge requests representer unit specs
7027243
@akabiru
tests[Op#53117]: add gitlab issues representer unit specs
aea2122
@akabiru
tests[Op#53117]: add gitlab merge request hook spec
8f319cb
@akabiru
tests[Op#53117]: add gitlab issue hook spec
14b5742
@akabiru
tests[Op#53117]: add gitlab pipeline happy path unit spec
5920015
@akabiru
tests[Op#53117]: add gitlab tab feature spec
bee5a12
@akabiru
tests[Op#53117]: fixup some inconsistencies on the hooks spec
0b5d405
@akabiru
tests[Op#53117]: fixup ambiguos class name, just assert against text
69ab47f
@akabiru
tests[Op#53117]: cover gitlab activity tab happy path
d18c623
@akabiru
chore[Op#53019]: bump version and add openproject as author
7c791a4
@akabiru
security[Op#53019]: clarify to security tool that there's no injectio…
0cc247f 
…n risk
akabiru
akabiru commented Mar 6, 2024
View reviewed changes
Copy link
Member Author

@akabiru akabiru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • @lindenthal URL to repo in plugin overview /admin/plugins updated ✅

7c791a4

Screenshot 2024-03-06 at 5 04 27 PM

@akabiru akabiru marked this pull request as ready for review March 6, 2024 14:26
@akabiru akabiru requested a review from ba1ash March 6, 2024 14:26
akabiru and others added 2 commits March 6, 2024 17:49
@akabiru @ba1ash
fix[Op#53019]: Good Job ClearOldMergeRequestsJob
a5eb528 
Co-Authored-by: Pavel Balashou <[email protected]>
@akabiru
Merge branch 'dev' into implementation/53019-bring-bteyopenproject-gi…
a69f06b 
…tlab-integration-into-a-structure-that-matches-openproject
@klaustopher klaustopher mentioned this pull request Mar 6, 2024
Closed
@akabiru
Merge pull request #14899 from opf/implementation/53117-add-automated…
53f950a 
…-tests-for-the-critical-path

Implementation/53117 Add automated tests for the critical path of gitlab integration
@akabiru akabiru merged commit 29b1cc0 into dev Mar 6, 2024
13 checks passed
@akabiru akabiru deleted the implementation/53019-bring-bteyopenproject-gitlab-integration-into-a-structure-that-matches-openproject branch March 6, 2024 18:14
@oliverguenther oliverguenther mentioned this pull request Mar 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ba1ash ba1ash ba1ash approved these changes

Assignees

@akabiru akabiru

Labels
contribution feature
Milestone
13.4
Development

Successfully merging this pull request may close these issues.
10 participants
@akabiru @ba1ash @lindenthal @btey @oliverguenther @BjoernLudwigPTB @wagner-petrosoft @foxweb @pustekuchen91 @WiredTombstone