Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ui-router from notifications #15840

Merged
merged 43 commits into from
Aug 1, 2024
Merged

Remove ui-router from notifications #15840

merged 43 commits into from
Aug 1, 2024

Conversation

oliverguenther
Copy link
Member

@oliverguenther oliverguenther commented Jun 13, 2024 •
edited
Loading

https://community.openproject.org/work_packages/55632

  • The sidebar component needs extensions

    • Notifications render icons
    • Notification count bubbles
    • Some of the options require an EE token, so we need to define an alternative link

  • Toolbar

  • Layout issues

    • The height of the page is currrently fixed to 100%, we need an alternative layout
    • Notification center has a split view that needs to be appended to the right side

  • Interactivity

    • Marking items as read needs to reload the sidebar (solved by frameElement.reload)
    • The number in the "Activity" tab header needs to update when a notification is read
    • Highlight the currently selected notification
    • Selecting a notification should preserve the current filters
    • (Optional) Do not render the whole page when switching between different work packages or closing the split view

@oliverguenther oliverguenther force-pushed the impl/ui-router-notifications branch from 872d63b to 00e87b3 Compare June 13, 2024 09:10
@oliverguenther oliverguenther force-pushed the impl/ui-router-notifications branch 4 times, most recently from d3ebd6e to 7ea53ce Compare June 19, 2024 09:22
@HDinger HDinger mentioned this pull request Jul 4, 2024
Merged
10 tasks
@oliverguenther oliverguenther force-pushed the impl/ui-router-notifications branch 3 times, most recently from 106878d to 2f1c4f7 Compare July 16, 2024 06:25
@oliverguenther oliverguenther force-pushed the impl/ui-router-notifications branch from c197f8b to 77d4399 Compare July 24, 2024 05:40
@HDinger HDinger force-pushed the impl/ui-router-notifications branch 3 times, most recently from b07c675 to ee1f4bf Compare July 25, 2024 12:46
@oliverguenther oliverguenther force-pushed the impl/ui-router-notifications branch from 3302a3b to b66c65b Compare July 26, 2024 08:09
oliverguenther and others added 19 commits July 26, 2024 10:32
@oliverguenther
Adapt specs
d18f9da
@oliverguenther
Fix underline styles
08bfdb8
@HDinger @oliverguenther
Render nicer Blankslate when the WorkPackage is not found
6d5bf0e
@HDinger @oliverguenther
Show two buttons at the end of the SplitScreen tabs for closing and g…
65d0ded 
…oing fullscreen. Take care that the buttons are correctly aligned, the tabs scroll and the border of the underlineNav is continued. Currently the close button is not working yet. (wip)
@HDinger @oliverguenther
Please linters
bce871a
@HDinger @oliverguenther
Pass a closing url to the split screen so that we know where to go to
c47ebed
@HDinger @oliverguenther
Change localisation key to avoid inconsistent interpolations between …
2767d89 
…languages
@HDinger @oliverguenther
Correctly highlight currently selected notification
b62a01a
@HDinger @oliverguenther
Re-add cost_reports routes which were deleted accidentally
defb145
@HDinger @oliverguenther
For angular scrollable tabs we still want the angular routing to take…
7593fb2 
… place
@HDinger @oliverguenther
Extract upsale pages into CustomComponents and render them on individ…
092d5cd 
…ual rails routes instead of Angular
@HDinger @oliverguenther
Adapt tests to new rails based routing of notification center
f03a703
@HDinger @oliverguenther
Add correct count to notification activity tab and preserve the filte…
024be50 
…r params when opening the split screen
@oliverguenther
Load split view as turbo stream
e96bd37
@oliverguenther
Close with turbo stream
6a93033
@oliverguenther
Add turbo power so we can change urls in turbo streams
743ea7c
@oliverguenther
Set title in turbo stream
617f9ff
@oliverguenther
Allow dynamically setting the page title
c85ccbc
@oliverguenther
Reverse the title parts
30aa9c7
@oliverguenther oliverguenther force-pushed the impl/ui-router-notifications branch from b66c65b to 30aa9c7 Compare July 26, 2024 08:32
@oliverguenther oliverguenther added this to the 14.5.x milestone Jul 26, 2024
@oliverguenther oliverguenther force-pushed the impl/ui-router-notifications branch from 3eef91c to c8f0418 Compare July 28, 2024 17:12
@oliverguenther oliverguenther marked this pull request as ready for review August 1, 2024 08:24
@HDinger HDinger merged commit cb118cf into dev Aug 1, 2024
9 of 11 checks passed
@HDinger HDinger deleted the impl/ui-router-notifications branch August 1, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
maintenance
Milestone
14.5.x
Development

Successfully merging this pull request may close these issues.
2 participants
@oliverguenther @HDinger