Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[55178] Replace sidemenu of team planner and boards with Rails component #15895

Merged
merged 3 commits into from
Jun 24, 2024
Merged

[55178] Replace sidemenu of team planner and boards with Rails component #15895

merged 3 commits into from
Jun 24, 2024

Conversation

HDinger
Copy link
Contributor

@HDinger HDinger commented Jun 19, 2024 •
edited
Loading

ToDo

  • Replace the angular sidebar component with the rails based Submenu component in:
    • the team planner module, Ticket
    • the boards module, Ticket
      • Update menu, when a board is renamed
  • Adapt onboarding tour to deal with the hard reloads between the modules

@HDinger HDinger added this to the 14.3.x milestone Jun 19, 2024
@HDinger HDinger requested a review from oliverguenther June 19, 2024 13:04
@HDinger HDinger force-pushed the implementation/55178-replace-sidemenu-of-team-planner-page-with-rails-component branch 4 times, most recently from e9bbec6 to 36a1bb8 Compare June 20, 2024 10:10
@HDinger HDinger force-pushed the implementation/55178-replace-sidemenu-of-team-planner-page-with-rails-component branch from e932e01 to 357ca0f Compare June 20, 2024 12:06
@HDinger HDinger changed the title [55178] Replace sidemenu of team planner page with Rails component [55178] Replace sidemenu of team planner and boards with Rails component Jun 20, 2024
@HDinger HDinger force-pushed the implementation/55178-replace-sidemenu-of-team-planner-page-with-rails-component branch 2 times, most recently from 24881cc to 42a72bf Compare June 21, 2024 06:51
@HDinger HDinger force-pushed the implementation/55178-replace-sidemenu-of-team-planner-page-with-rails-component branch from 03b2b99 to f94a6c8 Compare June 21, 2024 07:57
@HDinger HDinger requested a review from oliverguenther June 21, 2024 09:23
This was referenced Jun 21, 2024
Merged
Merged
@oliverguenther oliverguenther merged commit 8d14243 into dev Jun 24, 2024
10 checks passed
@oliverguenther oliverguenther deleted the implementation/55178-replace-sidemenu-of-team-planner-page-with-rails-component branch June 24, 2024 04:32
Eric-Guo added a commit to Eric-Guo/openproject that referenced this pull request Jun 26, 2024
@Eric-Guo
Revert "Merge pull request opf#15895 from opf/implementation/55178-re…
020d6c0 
…place-sidemenu-of-team-planner-page-with-rails-component"

This reverts commit 8d14243, reversing
changes made to db7a65e.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliverguenther oliverguenther Awaiting requested review from oliverguenther

Assignees
No one assigned
Labels
feature
Milestone
14.3.x
Development

Successfully merging this pull request may close these issues.
2 participants
@HDinger @oliverguenther