[55179] Harmonize submenu implementations of Meetings, Projects, and Members #15918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HDinger
force-pushed
the
implementation/55179-use-submenu-component-in-meetings-module
branch
from
c9cbddd to
bca9b47
Compare
cbliard
requested changes
Jun 26, 2024
There was a problem hiding this comment.
Nice refactoring.
It does not work well on the meetings page: whatever is selected, it's always the "Upcoming invitations" menu item which is selected. The page content is updated correctly. It happens for both global and project levels.
Code wise, I have some minor remarks. There were also some rubocop warnings that I fixed.
5 tasks
HDinger
force-pushed
the
implementation/55179-use-submenu-component-in-meetings-module
branch
2 times, most recently
from
68a709c to
85ef1a2
Compare
… are no filters added
HDinger
force-pushed
the
implementation/55179-use-submenu-component-in-meetings-module
branch
from
85ef1a2 to
c07cf31
Compare
HDinger
deleted the
implementation/55179-use-submenu-component-in-meetings-module
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up PR of #15895 (and other closely related PRs, see ticket relationship). In order to have a harmonized structure in code, the PR adapts the code structure of the existing
Common::SubmenuComponentimplementations ofFurther, the custom implementation for the submen of the meetings module was removed and replaced by a
Common::SubmenuComponentfollowing the same approach as in the other modules.https://community.openproject.org/projects/openproject/work_packages/55179/activity