[#55801] Add form validation in add project dialog for project attributes

[judithroth]

OP#55801

[akabiru]

Looks good to me, Judith! 👍🏾 I left some remarks tagged by the traffic light system (🟢 🟠 🔴 )

---

Some general Qs:

• 🟠 I noticed that we have a bit of a flicker now due to the split dialog render- I presume this is acceptable UX as the respond_with_dialog already existed?

  flicker-add-projects-attributes.mp4

• 🟢 I wonder if there's any further padding or restructuring we can do to the modal body to stop the "X" icon hover state touching the autocompleter input. Right now it's a bit of an eye sore 😬

[judithroth]

Looks good to me, Judith! 👍🏾 I left some remarks tagged by the traffic light system (🟢 🟠 🔴 )

Some general Qs:

* [ ]  🟠 I noticed that we have a bit of a flicker now due to the split dialog render- I presume this is acceptable UX as the `respond_with_dialog` already existed?

I assume this is the case. After you mentioned it, I saw the flickering too (it only happens on the first time after the page is loaded). I used the pattern described in the lookbook "Async dialogs as turbo streams". Actually I'm not sure how I could fix it.

      flicker-add-projects-attributes.mp4

* [ ]  🟢 I wonder if there's any further padding or restructuring we can do to the modal body to stop the "X" icon hover state touching the autocompleter input. Right now it's a bit of an eye sore 😬

Well... one of my last code clean ups obviously removed the dialog header text. After readding the header title the eye sore is gone again and the icon hover and the input don't snuggle any more:

[akabiru]

Thanks for addressing the feedback, looking good!

[akabiru]

⚠️ @judithroth reminder to change the branch base to dev

[judithroth]

Force push / rebase because of changing the base branch - when I started working on this, I thought it was going into the release/14.2 branch, but it should go into dev.