Separate OmniAuth controller from Account controller #16552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
oliverguenther
force-pushed
the
chore/omniauth-setup-controller
branch
4 times, most recently
from
e23570c to
1997173
Compare
oliverguenther
force-pushed
the
chore/omniauth-setup-controller
branch
from
1997173 to
e96b53a
Compare
machisuji
reviewed
Sep 19, 2024
machisuji
requested changes
Sep 19, 2024
oliverguenther
force-pushed
the
chore/omniauth-setup-controller
branch
from
e96b53a to
982ce8d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
In preparation to add more functionality to the omniauth routes, specifically a setup route, I wanted to separate out the omniauth specific functionality from the concern mounted to AccountController into its own controller.
https://community.openproject.org/work_packages/57951