Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[53810] Update PageHeaders & SubHeaders in the (rails) project pages #17103

Merged
merged 64 commits into from
Dec 6, 2024
Merged

[53810] Update PageHeaders & SubHeaders in the (rails) project pages #17103

merged 64 commits into from
Dec 6, 2024

Conversation

bsatarnejad
Copy link
Contributor

@bsatarnejad bsatarnejad commented Nov 4, 2024 •
edited by HDinger
Loading

Ticket

https://community.openproject.org/projects/openproject/work_packages/53810/activity

What are you trying to accomplish?

Replace page header and subHeader in project-related rails pages, except:

  • wiki pages
  • repository

What approach did you choose and why?

  • There is one special thing to consider: The project setting pages have a "check all/uncheck all" link in the header. We dropped that feature, in agreement with product and wait for feedback on that. If people miss it, we will add it somewhere else on the page.

Merge checklist

  • Added/updated tests

@bsatarnejad
update page header in project settings
e12f11b
@bsatarnejad
remove confirmation from templated button
92c8bf9
@bsatarnejad
add page header fo adding news
2a5450e
@bsatarnejad
update page header in roadmap
6988b01
@bsatarnejad
update page header in new version page
0199254
@bsatarnejad
update page header in new versions page
a2ed799
@bsatarnejad
update page header in forums
ce34cf2
@bsatarnejad
update page header in new forum page
2da1820
@bsatarnejad
move create button form header to subheader in versions pages
400c3cc
@bsatarnejad
change header in new board page
723eb33
@bsatarnejad
change header in backlogs page
c86bcc2
@bsatarnejad
change header in edit version page
4b08052
@bsatarnejad
change html title in edit version page
b7ce95a
@bsatarnejad
change page header in budget page
45656db
@bsatarnejad
change page header in forum index page and change class of watcher li…
93a78fa 
…nk to look same as other primer buttons
@bsatarnejad
change page header in forum new message page
e60dd48
@bsatarnejad
update page header in budget new page
a963711
@bsatarnejad
update page header in budget show page
4e7d693
@bsatarnejad
update page header in budget edit page
d4b7717
@bsatarnejad
add a confirmation for delete method in budget form
8e7bb61
@bsatarnejad
move header action to subheader in forums
3013dd1
@bsatarnejad
update page header in edit forum page
989b8b4
@bsatarnejad
update page header in documents pages
567c401
@bsatarnejad
update page header in work package categories pages
e397666
@bsatarnejad
update page header in boards pages
18de94e
@bsatarnejad
update page header in boards pages
d814a0e
@bsatarnejad
update page header in new calendar page
e99ade6
@bsatarnejad
update page header in destroy category page
ccbf1e6
@bsatarnejad
change page header breadcrumbs for edit and destroy categories
f39f61c
@bsatarnejad
change watcher helper that can be used in page header action buttons
21178a2
bsatarnejad and others added 11 commits November 16, 2024 13:42
@bsatarnejad
update page header in copy project
de07f40
@bsatarnejad
update page header in repository pages of a project
b17b897
@bsatarnejad
update page header in storages pages of a project
16e91c6
@bsatarnejad
Merge branch 'dev' into 53810-update-pageheaders-subheaders-in-the-ra…
bd3fb3e 
…ils-project-pages
@bsatarnejad
update page header in attachment tab in storages of a project
29e336a
@HDinger
Replace pageHeaders with "check all/uncheck all" links with Primer co…
5c7ec9e 
…mponents. Thereby we drop that functionality for now. If we want to re-add it, we have to put it as part of the content
@HDinger
Correct some usages of Primer::PageHeader
41ace84
@HDinger
Replace rails toolbars with Primer::PageHeader in BCF module
a581547
@HDinger
Replace some more PageHeaders with the Primer component
087dad8
@HDinger
Merge branch 'dev' into 53810-update-pageheaders-subheaders-in-the-ra…
5356b49 
…ils-project-pages
@HDinger
Extract project settings pageHeader into a separate component
681dcf2
@HDinger HDinger modified the milestones: 15.1.x, 15.2.x Nov 26, 2024
HDinger
HDinger approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@HDinger HDinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to merge once the tests are green 👍

@HDinger HDinger merged commit 9a5e2ff into dev Dec 6, 2024
11 checks passed
@HDinger HDinger deleted the 53810-update-pageheaders-subheaders-in-the-rails-project-pages branch December 6, 2024 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HDinger HDinger HDinger approved these changes

Assignees
No one assigned
Labels
feature
Milestone
15.2.x
Development

Successfully merging this pull request may close these issues.
2 participants
@bsatarnejad @HDinger